From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6744 invoked by alias); 3 Oct 2008 19:04:13 -0000 Received: (qmail 6655 invoked by uid 22791); 3 Oct 2008 19:04:12 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out3.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Oct 2008 19:03:34 +0000 Received: from spaceape13.eur.corp.google.com (spaceape13.eur.corp.google.com [172.28.16.147]) by smtp-out.google.com with ESMTP id m93J3MXu017976 for ; Fri, 3 Oct 2008 20:03:22 +0100 Received: from rv-out-0708.google.com (rvbk29.prod.google.com [10.140.87.29]) by spaceape13.eur.corp.google.com with ESMTP id m93J3Kwp012796 for ; Fri, 3 Oct 2008 12:03:21 -0700 Received: by rv-out-0708.google.com with SMTP id k29so1596441rvb.4 for ; Fri, 03 Oct 2008 12:03:20 -0700 (PDT) Received: by 10.141.18.12 with SMTP id v12mr885759rvi.183.1223060599951; Fri, 03 Oct 2008 12:03:19 -0700 (PDT) Received: by 10.140.201.10 with HTTP; Fri, 3 Oct 2008 12:03:19 -0700 (PDT) Message-ID: Date: Fri, 03 Oct 2008 19:04:00 -0000 From: "Doug Evans" To: "Michael Snyder" Subject: Re: [RFA] Reverse Debugging, 1/5 Cc: "gdb-patches@sourceware.org" , "Daniel Jacobowitz" , "Pedro Alves" , teawater In-Reply-To: <48E3CCB6.4060501@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <48E3CCB6.4060501@vmware.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00093.txt.bz2 On Wed, Oct 1, 2008 at 12:17 PM, Michael Snyder wrote: > > > This first patch of the reverse debugging sequence affects > only the target_ops interface (adding several target methods > and some enums and such). > > Adding this patch alone does not affect gdb's behavior, and > I have run testsuites under RHEL with no change in results. > > > 2008-09-30 Michael Snyder > Target interface for reverse debugging. > * target.h (enum target_waitkind): > Add new wait event, TARGET_WAITKIND_NO_HISTORY. > (enum exec_direction_kind): New enum. > (struct target_ops): New methods to_set_execdir, to_get_execdir. > * target.c (target_get_execdir): New generic method. > (target_set_execdir): Ditto. > > Index: target.c > =================================================================== > RCS file: /cvs/src/src/gdb/target.c,v > retrieving revision 1.184 > diff -u -p -r1.184 target.c > --- target.c 22 Sep 2008 15:21:30 -0000 1.184 > +++ target.c 30 Sep 2008 18:19:00 -0000 > @@ -455,6 +455,8 @@ update_current_target (void) > INHERIT (to_find_memory_regions, t); > INHERIT (to_make_corefile_notes, t); > INHERIT (to_get_thread_local_address, t); > + INHERIT (to_get_execdir, t); > + INHERIT (to_set_execdir, t); > /* Do not inherit to_read_description. */ > /* Do not inherit to_search_memory. */ > INHERIT (to_magic, t); > Index: target.h > =================================================================== > RCS file: /cvs/src/src/gdb/target.h,v > retrieving revision 1.130 > diff -u -p -r1.130 target.h > --- target.h 19 Aug 2008 13:22:14 -0000 1.130 > +++ target.h 30 Sep 2008 18:19:00 -0000 > @@ -128,7 +128,11 @@ enum target_waitkind > inferior, rather than being stuck in the remote_async_wait() > function. This way the event loop is responsive to other events, > like for instance the user typing. */ > - TARGET_WAITKIND_IGNORE > + TARGET_WAITKIND_IGNORE, > + > + /* The target has run out of history information, > + and cannot run backward any further. */ > + TARGET_WAITKIND_NO_HISTORY > }; > > struct target_waitstatus > @@ -147,6 +151,14 @@ struct target_waitstatus > value; > }; > > +/* Reverse execution. */ > +enum exec_direction_kind > + { > + EXEC_FORWARD, > + EXEC_REVERSE, > + EXEC_ERROR > + }; > + > /* Possible types of events that the inferior handler will have to > deal with. */ > enum inferior_event_type > @@ -523,6 +535,11 @@ struct target_ops > const gdb_byte *pattern, ULONGEST pattern_len, > CORE_ADDR *found_addrp); > > + /* Set execution direction (forward/reverse). */ > + int (*to_set_execdir) (enum exec_direction_kind); > + /* Get execution direction (forward/reverse). */ > + enum exec_direction_kind (*to_get_execdir) (void); > + > int to_magic; > /* Need sub-structure for target machine related rather than comm > related? > */ > @@ -1127,6 +1144,18 @@ extern int target_stopped_data_address_p > #define target_watchpoint_addr_within_range(target, addr, start, length) \ > (*target.to_watchpoint_addr_within_range) (target, addr, start, length) > > +/* Forward/reverse execution direction. > + These will only be implemented by a target that supports reverse > execution. > +*/ > +#define target_get_execution_direction() \ > + (current_target.to_get_execdir ? \ > + (*current_target.to_get_execdir) () : EXEC_ERROR) > + > +#define target_set_execution_direction(DIR) \ > + (current_target.to_set_execdir ? \ > + (*current_target.to_set_execdir) (DIR) : EXEC_ERROR) > + > + > extern const struct target_desc *target_read_description (struct target_ops > *); > > /* Utility implementation of searching memory. */ Hi. Nit: Can all occurrences of "execdir" be replaced with "exec_direction"? I look at "execdir" and think "execution directory". [I realize often the context provides enough clues that prevent this misinterpretation, but that's not always true.]