From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18788 invoked by alias); 23 Jul 2008 22:47:54 -0000 Received: (qmail 18780 invoked by uid 22791); 23 Jul 2008 22:47:54 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 Jul 2008 22:47:36 +0000 Received: from wpaz17.hot.corp.google.com (wpaz17.hot.corp.google.com [172.24.198.81]) by smtp-out.google.com with ESMTP id m6NMlFa6026617 for ; Wed, 23 Jul 2008 23:47:15 +0100 Received: from yw-out-1718.google.com (ywm5.prod.google.com [10.192.13.5]) by wpaz17.hot.corp.google.com with ESMTP id m6NMklnn007526 for ; Wed, 23 Jul 2008 15:47:14 -0700 Received: by yw-out-1718.google.com with SMTP id 5so5396117ywm.22 for ; Wed, 23 Jul 2008 15:47:14 -0700 (PDT) Received: by 10.142.237.19 with SMTP id k19mr160822wfh.86.1216853234131; Wed, 23 Jul 2008 15:47:14 -0700 (PDT) Received: by 10.140.201.10 with HTTP; Wed, 23 Jul 2008 15:47:14 -0700 (PDT) Message-ID: Date: Wed, 23 Jul 2008 22:47:00 -0000 From: "Doug Evans" To: "Eli Zaretskii" Subject: Re: [RFA] set print symbol-loading on|off Cc: gdb-patches@sourceware.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080710203701.6AF041C769A@localhost> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00422.txt.bz2 [apologies, resending 'cus gmail sent mime and the ml doesn't like mime] On Sat, Jul 19, 2008 at 3:37 PM, Eli Zaretskii wrote: > > > Date: Thu, 10 Jul 2008 13:37:01 -0700 (PDT) > > From: dje@google.com (Doug Evans) > > > > Along the lines of "set print thread-events on|off", > > this option lets one turn off symbol loading messages. > > If the app has *lots* of shared libraries, these messages > > can be more noise than signal. > > Thanks. > > > --- NEWS 10 Jul 2008 16:44:47 -0000 1.280 > > +++ NEWS 10 Jul 2008 20:16:31 -0000 > > @@ -68,6 +68,10 @@ find [/size-char] [/max-count] start-add > > val1 [, val2, ...] > > Search memory for a sequence of bytes. > > > > +set print symbol-loading > > +show print symbol-loading > > + Control printing of symbol loading messages. > > This is okay. > > > - printf_unfiltered (_("Reading symbols from %s..."), name); > > - wrap_here (""); > > - gdb_flush (gdb_stdout); > > + if (print_symbol_loading) > > + { > > + printf_unfiltered (_("Reading symbols from %s..."), name); > > + wrap_here (""); > > + gdb_flush (gdb_stdout); > > + } > > I'm not sure doing this in complete silence is a good idea. You've > shut up GDB, but this phase could take a long time, during which GDB > will appear to be hung. How about printing a single message, like > "Reading symbols ..."? Any ideas where such a message should be printed? I'm guessing you'd want it printed in all the user-commands that might call this lowish-level routine, but that's just a guess. > > > + add_setshow_boolean_cmd ("symbol-loading", no_class, > > + &print_symbol_loading, _("\ > > +Set printing of symbol loading messages."), _("\ > > +Show printing of symbol loading messages."), NULL, > > This is not enough detail. As written, this doc string doesn't really > document anything in a useful manner. Please add an explanation of > what this does, e.g. "When ON (the default), GDB will print messages > about loading symbols from shared libraries and debug info files." Monkey-see monkey-do hacking from the "set print thread-events" patch. Any suggestions if/how that needs to be enhanced as well? thread.c: add_setshow_boolean_cmd ("thread-events", no_class, &print_thread_events, _("\ Set printing of thread events (such as thread start and exit)."), _("\ Show printing of thread events (such as thread start and exit)."), NULL, NULL, show_print_thread_events, &setprintlist, &showprintlist); > > > Index: doc/gdb.texinfo > > =================================================================== > > RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v > > This part is okay. Thanks.