From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28325 invoked by alias); 9 May 2008 02:52:07 -0000 Received: (qmail 28312 invoked by uid 22791); 9 May 2008 02:52:06 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 May 2008 02:51:42 +0000 Received: from zps78.corp.google.com (zps78.corp.google.com [172.25.146.78]) by smtp-out.google.com with ESMTP id m492pZmo032764 for ; Fri, 9 May 2008 03:51:36 +0100 Received: from wa-out-1112.google.com (wafl35.prod.google.com [10.114.188.35]) by zps78.corp.google.com with ESMTP id m492pYIf011786 for ; Thu, 8 May 2008 19:51:34 -0700 Received: by wa-out-1112.google.com with SMTP id l35so1289338waf.16 for ; Thu, 08 May 2008 19:51:34 -0700 (PDT) Received: by 10.114.92.6 with SMTP id p6mr3751175wab.178.1210301494580; Thu, 08 May 2008 19:51:34 -0700 (PDT) Received: by 10.114.254.4 with HTTP; Thu, 8 May 2008 19:51:29 -0700 (PDT) Message-ID: Date: Fri, 09 May 2008 06:35:00 -0000 From: "Doug Evans" To: gdb-patches@sourceware.org Subject: Re: [RFA] new command to search memory In-Reply-To: <20080502151742.GM29202@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080214021915.F3FE51C72F0@localhost> <20080226022335.GB4456@caradoc.them.org> <20080229031252.GA2897@caradoc.them.org> <20080502151742.GM29202@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00305.txt.bz2 On Fri, May 2, 2008 at 8:17 AM, Daniel Jacobowitz wrote: >> Index: gdbserver/Makefile.in >> =================================================================== >> RCS file: /cvs/src/src/gdb/gdbserver/Makefile.in,v >> retrieving revision 1.57 >> diff -u -p -u -p -r1.57 Makefile.in >> --- gdbserver/Makefile.in 14 Apr 2008 18:04:00 -0000 1.57 >> +++ gdbserver/Makefile.in 17 Apr 2008 02:35:24 -0000 >> @@ -81,11 +81,15 @@ BFD_CFLAGS = -I$(BFD_DIR) -I$(BFD_SRC) >> READLINE_DIR = ${srcdir}/../readline >> READLINE_DEP = $$(READLINE_DIR) >> >> +# gnulib >> +INCGNULIB = -I$(srcdir)/../gnulib -I../gnulib >> + >> # All the includes used for CFLAGS and for lint. >> # -I. for config files. >> # -I${srcdir} for our headers. >> # -I$(srcdir)/../regformats for regdef.h. >> -INCLUDE_CFLAGS = -I. -I${srcdir} -I$(srcdir)/../regformats -I$(INCLUDE_DIR) >> +INCLUDE_CFLAGS = -I. -I${srcdir} -I$(srcdir)/../regformats -I$(INCLUDE_DIR) \ >> + $(INCGNULIB) >> >> # M{H,T}_CFLAGS, if defined, has host- and target-dependent CFLAGS >> # from the config/ directory. >> @@ -143,7 +147,7 @@ TAGFILES = $(SOURCES) ${HFILES} ${ALLPAR >> >> OBS = inferiors.o regcache.o remote-utils.o server.o signals.o target.o \ >> utils.o version.o \ >> - mem-break.o hostio.o \ >> + mem-break.o memmem.o hostio.o \ >> $(XML_BUILTIN) \ >> $(DEPFILES) $(LIBOBJS) >> GDBSERVER_LIBS = @GDBSERVER_LIBS@ > > The gdbserver configure script should already be taking care of all > these. In particular we don't want to reference ../gnulib in the > objdir since it won't exist if you're just building gdbserver. And I > know it will add memmem.o, I tested that. I thought gnulib/memmem.o was always going to be used. We started down this path because, in part, libc's memmem is O(n^2). configure ... checking for memmem... yes after making gdbserver ... $ nm gdbserver | grep memmem U memmem@@GLIBC_2.0 > Does that leave just the declaration? You can stick it somewhere in > gdbserver instead of bringing in all the replacement gnulib headers.