From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7993 invoked by alias); 16 Apr 2008 19:31:38 -0000 Received: (qmail 7983 invoked by uid 22791); 16 Apr 2008 19:31:37 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 16 Apr 2008 19:31:20 +0000 Received: from zps75.corp.google.com (zps75.corp.google.com [172.25.146.75]) by smtp-out.google.com with ESMTP id m3GJVBUX017779 for ; Wed, 16 Apr 2008 20:31:11 +0100 Received: from wa-out-1112.google.com (wafj37.prod.google.com [10.114.186.37]) by zps75.corp.google.com with ESMTP id m3GJV0vF024622 for ; Wed, 16 Apr 2008 12:31:10 -0700 Received: by wa-out-1112.google.com with SMTP id j37so4192463waf.7 for ; Wed, 16 Apr 2008 12:31:10 -0700 (PDT) Received: by 10.114.170.1 with SMTP id s1mr556868wae.133.1208374270432; Wed, 16 Apr 2008 12:31:10 -0700 (PDT) Received: by 10.115.107.18 with HTTP; Wed, 16 Apr 2008 12:31:10 -0700 (PDT) Message-ID: Date: Wed, 16 Apr 2008 21:22:00 -0000 From: "Doug Evans" To: "Joel Brobecker" Subject: Re: [RFA] mixed source+assembly from cli disassemble Cc: gdb-patches@sourceware.org In-Reply-To: <20080416185535.GB3626@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080404003857.A5A451C72B9@localhost> <20080416185535.GB3626@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00308.txt.bz2 On Wed, Apr 16, 2008 at 11:55 AM, Joel Brobecker wrote: > Doug, > > > > 2008-04-03 Doug Evans > > > > * cli/cli-cmds.c (print_disassembly): New fn. > > (disassemble_current_function): New fn. > > (disassemble_command): Recognize /s modifier, print mixed > > source+assembly. > > (init_cli_cmds): Update disassemble help text. > > MichaelS already approved the patch, and I agree with him. I had some > comments, and a request so I'm sending them now. > > First, the request: Can you also write up a NEWS entry? I think this > is a great addition and it deserves a mention in NEWS. Ok. > > The ChangeLog is missing the entry for the documentation update. Please > make sure that EliZ has seen it before checking in. I'm not sure > whether this is the case or not anymore. Sorry, creature of habit. Way back when such changelog entries were never done (per gnu coding standards). > I also personally prefer to avoid abbreviations such as "fn", although > the GNU coding standards say nothing against them - so it may only be > a personally preference. I see that it has been use a few times in > the past, but most uses is in the 90s. Don't change it unless other > maintainers agree that it should be changed. > > > > + printf_filtered ("from "); > > + deprecated_print_address_numeric (low, 1, gdb_stdout); > > + printf_filtered (" to "); > > + deprecated_print_address_numeric (high, 1, gdb_stdout); > > + printf_filtered (":\n"); > > While you are modifying this code, I think the following should work too: > > printf_filtered ("form %s to %s:\n", paddress (low), paddress (high)); > > Not only does this help us get rid of a couple of uses of deprecated > functions, I believe it's also better for i18n. Righto.