Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Doug Evans" <dje@google.com>
To: "Aleksandar Ristovski" <ARistovski@qnx.com>
Cc: "GDB Patches" <gdb-patches@sourceware.org>
Subject: Re: [RFA] patch for DW_AT_comp_dir/DW_AT_name vs .debug_line inco nsistencies
Date: Wed, 09 Apr 2008 20:52:00 -0000	[thread overview]
Message-ID: <e394668d0804091103x1e768217wbec95cd191dbb5f9@mail.gmail.com> (raw)
In-Reply-To: <47FCC953.8060008@qnx.com>

On Wed, Apr 9, 2008 at 6:49 AM, Aleksandar Ristovski <ARistovski@qnx.com> wrote:
>
> Doug Evans wrote:
>  > On Mon, Apr 7, 2008 at 10:41 PM, Doug Evans <dje@google.com> wrote:
>  >> I have an occasion to revisit this:
>  >>  http://sourceware.org/ml/gdb-patches/2007-11/msg00314.html
>  >>
>  >>  Or in a different form:
>  >>  http://sourceware.org/ml/gdb-patches/2008-01/msg00103.html
>  >>
>  >>  When we last left our story, watching for a single path mismatch of
>  >>  the main source file only seemed ok.  That's what this patch does.
>  >>  It's just a minor revision of
>  >>  http://sourceware.org/ml/gdb-patches/2008-01/msg00103.html
>  >
>  > While reading end_symtab I was inspired to try again for a
>  > debug-format independent solution.
>  >
>  >
>  Haven't tested, just thinking: Will it work in this case:
>
>  Let's imagine we have two files
>  /.../foo/bar.c
>  /.../foo/baz/bar.c
>
>  First file goes something like this:
>  ..
>  #include "baz/bar.c"
>  ...
>
>  In that case we will have lbasename(mainsub->name) == "bar.c"
>  and (strcmp (lbasename (subfile->name), mainbase) == 0) (since lbasename
>  ("/../foo/baz/bar.c" == "bar.c")
>
>  So if I am not mistaken, you would have nr_matches == 1 which would lead to
>  losing info about one of the files.

In the case where /.../foo/bar.c doesn't contain anything that would
require line number info itself (e.g. all it does is #include
"/.../foo/baz/bar.c") then yes information will be lost, but in this
case there's not much information to lose ...


  reply	other threads:[~2008-04-09 18:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-09 14:55 Aleksandar Ristovski
2008-04-09 20:52 ` Doug Evans [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-04-08 16:37 Aleksandar Ristovski
2008-01-08 21:51 Aleksandar Ristovski
2008-01-08 21:57 ` Daniel Jacobowitz
2008-01-08 21:26 Aleksandar Ristovski
2008-01-08 21:24 Aleksandar Ristovski
2008-01-08 21:32 ` Daniel Jacobowitz
2008-01-08 20:28 Aleksandar Ristovski
2008-01-08 20:33 ` Daniel Jacobowitz
2008-01-08 16:34 Aleksandar Ristovski
2008-01-08 16:46 ` Daniel Jacobowitz
2008-01-08 16:10 Aleksandar Ristovski
2008-01-08 16:19 ` Daniel Jacobowitz
2008-01-08 17:33 ` Doug Evans
2008-01-06  6:44 Aleksandar Ristovski
2008-01-06 18:44 ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e394668d0804091103x1e768217wbec95cd191dbb5f9@mail.gmail.com \
    --to=dje@google.com \
    --cc=ARistovski@qnx.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox