From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3131 invoked by alias); 3 Apr 2008 17:55:37 -0000 Received: (qmail 3122 invoked by uid 22791); 3 Apr 2008 17:55:36 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 03 Apr 2008 17:55:20 +0000 Received: from zps36.corp.google.com (zps36.corp.google.com [172.25.146.36]) by smtp-out.google.com with ESMTP id m33HspQE017250 for ; Thu, 3 Apr 2008 18:54:51 +0100 Received: from el-out-1112.google.com (elev27.prod.google.com [10.126.173.27]) by zps36.corp.google.com with ESMTP id m33Hsnmv005827 for ; Thu, 3 Apr 2008 10:54:50 -0700 Received: by el-out-1112.google.com with SMTP id v27so1658085ele.12 for ; Thu, 03 Apr 2008 10:54:49 -0700 (PDT) Received: by 10.115.95.1 with SMTP id x1mr272862wal.7.1207245288948; Thu, 03 Apr 2008 10:54:48 -0700 (PDT) Received: by 10.115.107.18 with HTTP; Thu, 3 Apr 2008 10:54:48 -0700 (PDT) Message-ID: Date: Thu, 03 Apr 2008 18:13:00 -0000 From: "Doug Evans" To: "GDB Patches" Subject: [RFA] remove free_contents MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_3658_30969975.1207245288943" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00072.txt.bz2 ------=_Part_3658_30969975.1207245288943 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 767 Hi. symtab.h contains this: struct general_symbol_info { /* Name of the symbol. This is a required field. Storage for the name is allocated on the objfile_obstack for the associated objfile. ... */ char *name; [...] #define DEPRECATED_SYMBOL_NAME(symbol) (symbol)->ginfo.name but symmisc.c does this: static void free_symtab_block (struct objfile *objfile, struct block *b) { [...] xfree (DEPRECATED_SYMBOL_NAME (sym)); [...] } Either the comment is incomplete (i.e. some names are not allocated on an objfile_obstack), or the code is wrong (or in this case, outdated). There's a FIXME that says free_symtab_block is likely never used and that is the case. free_contents is never used, which is how free_symtab_block would get called. ------=_Part_3658_30969975.1207245288943 Content-Type: text/x-patch; name=gdb-080403-free-contents.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_felmn8md0 Content-Disposition: attachment; filename=gdb-080403-free-contents.patch Content-length: 4913 MjAwOC0wNC0wMyAgRG91ZyBFdmFucyAgPGRqZUBzZWJhYmVhY2gub3JnPgoK CSogc3ltdGFiLmggKGVudW0gZnJlZV9jb2RlKTogRGVsZXRlIGZyZWVfY29u dGVudHMsIHVudXNlZC4KCSogc3ltbWlzYy5jIChmcmVlX3N5bXRhYl9ibG9j ayk6IERlbGV0ZS4KCShmcmVlX3N5bXRhYiwgY2FzZSBmcmVlX2NvZGUpOiBE ZWxldGUuCgpJbmRleDogc3ltbWlzYy5jCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvc3ltbWlzYy5jLHYKcmV0 cmlldmluZyByZXZpc2lvbiAxLjQ4CmRpZmYgLXUgLXAgLXIxLjQ4IHN5bW1p c2MuYwotLS0gc3ltbWlzYy5jCTE3IE1hciAyMDA4IDE1OjA1OjQyIC0wMDAw CTEuNDgKKysrIHN5bW1pc2MuYwkzIEFwciAyMDA4IDE3OjM5OjA5IC0wMDAw CkBAIC03MCw4ICs3MCw2IEBAIHN0YXRpYyBpbnQgYmxvY2tfZGVwdGggKHN0 cnVjdCBibG9jayAqKTsKIHN0YXRpYyB2b2lkIHByaW50X3BhcnRpYWxfc3lt Ym9scyAoc3RydWN0IHBhcnRpYWxfc3ltYm9sICoqLCBpbnQsCiAJCQkJICAg Y2hhciAqLCBzdHJ1Y3QgdWlfZmlsZSAqKTsKIAotc3RhdGljIHZvaWQgZnJl ZV9zeW10YWJfYmxvY2sgKHN0cnVjdCBvYmpmaWxlICosIHN0cnVjdCBibG9j ayAqKTsKLQogdm9pZCBfaW5pdGlhbGl6ZV9zeW1taXNjICh2b2lkKTsKIAog c3RydWN0IHByaW50X3N5bWJvbF9hcmdzCkBAIC04MiwzNyArODAsMTIgQEAg c3RydWN0IHByaW50X3N5bWJvbF9hcmdzCiAgIH07CiAKIHN0YXRpYyBpbnQg cHJpbnRfc3ltYm9sICh2b2lkICopOwotCi1zdGF0aWMgdm9pZCBmcmVlX3N5 bXRhYl9ibG9jayAoc3RydWN0IG9iamZpbGUgKiwgc3RydWN0IGJsb2NrICop OwogDAotCi0vKiBGcmVlIGEgc3RydWN0IGJsb2NrIDwtIEIgYW5kIGFsbCB0 aGUgc3ltYm9scyBkZWZpbmVkIGluIHRoYXQgYmxvY2suICAqLwotCi0vKiBG SVhNRTogY2FybHRvbi8yMDAzLTA0LTI4OiBJIGRvbid0IGJlbGlldmUgdGhp cyBpcyBjdXJyZW50bHkgZXZlcgotICAgdXNlZC4gICovCi0KLXN0YXRpYyB2 b2lkCi1mcmVlX3N5bXRhYl9ibG9jayAoc3RydWN0IG9iamZpbGUgKm9iamZp bGUsIHN0cnVjdCBibG9jayAqYikKLXsKLSAgc3RydWN0IGRpY3RfaXRlcmF0 b3IgaXRlcjsKLSAgc3RydWN0IHN5bWJvbCAqc3ltOwotCi0gIEFMTF9CTE9D S19TWU1CT0xTIChiLCBpdGVyLCBzeW0pCi0gICAgewotICAgICAgeGZyZWUg KERFUFJFQ0FURURfU1lNQk9MX05BTUUgKHN5bSkpOwotICAgICAgeGZyZWUg KHN5bSk7Ci0gICAgfQotCi0gIGRpY3RfZnJlZSAoQkxPQ0tfRElDVCAoYikp OwotICB4ZnJlZSAoYik7Ci19Ci0KIC8qIEZyZWUgYWxsIHRoZSBzdG9yYWdl IGFzc29jaWF0ZWQgd2l0aCB0aGUgc3RydWN0IHN5bXRhYiA8LSBTLgotICAg Tm90ZSB0aGF0IHNvbWUgc3ltdGFicyBoYXZlIGNvbnRlbnRzIG1hbGxvYydl ZCBzdHJ1Y3R1cmUgYnkgc3RydWN0dXJlLAotICAgd2hpbGUgc29tZSBoYXZl IGNvbnRlbnRzIHRoYXQgYWxsIGxpdmUgaW5zaWRlIG9uZSBiaWcgYmxvY2sg b2YgbWVtb3J5LAotICAgYW5kIHNvbWUgc2hhcmUgdGhlIGNvbnRlbnRzIG9m IGFub3RoZXIgc3ltYm9sIHRhYmxlIGFuZCBzbyB5b3Ugc2hvdWxkCi0gICBu b3QgZnJlZSB0aGUgY29udGVudHMgb24gdGhlaXIgYmVoYWxmIChleGNlcHQg c29tZXRpbWVzIHRoZSBsaW5ldGFibGUsCi0gICB3aGljaCBtYXliZSBwZXIg c3ltdGFiIGV2ZW4gd2hlbiB0aGUgcmVzdCBpcyBub3QpLgorICAgTm90ZSB0 aGF0IHNvbWUgc3ltdGFicyBoYXZlIGNvbnRlbnRzIHRoYXQgYWxsIGxpdmUg aW5zaWRlIG9uZSBiaWcgYmxvY2sgb2YKKyAgIG1lbW9yeSwgYW5kIHNvbWUg c2hhcmUgdGhlIGNvbnRlbnRzIG9mIGFub3RoZXIgc3ltYm9sIHRhYmxlIGFu ZCBzbyB5b3UKKyAgIHNob3VsZCBub3QgZnJlZSB0aGUgY29udGVudHMgb24g dGhlaXIgYmVoYWxmIChleGNlcHQgc29tZXRpbWVzIHRoZQorICAgbGluZXRh YmxlLCB3aGljaCBtYXliZSBwZXIgc3ltdGFiIGV2ZW4gd2hlbiB0aGUgcmVz dCBpcyBub3QpLgogICAgSXQgaXMgcy0+ZnJlZV9jb2RlIHRoYXQgc2F5cyB3 aGljaCBhbHRlcm5hdGl2ZSB0byB1c2UuICAqLwogCiB2b2lkCkBAIC0xMjks MTggKzEwMiw2IEBAIGZyZWVfc3ltdGFiIChzdHJ1Y3Qgc3ltdGFiICpzKQog ICAgICAgICAgVGhlcmVmb3JlLCBkbyBub3RoaW5nLiAgKi8KICAgICAgIGJy ZWFrOwogCi0gICAgY2FzZSBmcmVlX2NvbnRlbnRzOgotICAgICAgLyogSGVy ZSBhbGwgdGhlIGNvbnRlbnRzIHdlcmUgbWFsbG9jJ2VkIHN0cnVjdHVyZSBi eSBzdHJ1Y3R1cmUKLSAgICAgICAgIGFuZCBtdXN0IGJlIGZyZWVkIHRoYXQg d2F5LiAgKi8KLSAgICAgIC8qIEZpcnN0IGZyZWUgdGhlIGJsb2NrcyAoYW5k IHRoZWlyIHN5bWJvbHMuICAqLwotICAgICAgYnYgPSBCTE9DS1ZFQ1RPUiAo cyk7Ci0gICAgICBuID0gQkxPQ0tWRUNUT1JfTkJMT0NLUyAoYnYpOwotICAg ICAgZm9yIChpID0gMDsgaSA8IG47IGkrKykKLQlmcmVlX3N5bXRhYl9ibG9j ayAocy0+b2JqZmlsZSwgQkxPQ0tWRUNUT1JfQkxPQ0sgKGJ2LCBpKSk7Ci0g ICAgICAvKiBGcmVlIHRoZSBibG9ja3ZlY3RvciBpdHNlbGYuICAqLwotICAg ICAgeGZyZWUgKGJ2KTsKLSAgICAgIC8qIEFsc28gZnJlZSB0aGUgbGluZXRh YmxlLiAgKi8KLQogICAgIGNhc2UgZnJlZV9saW5ldGFibGU6CiAgICAgICAv KiBFdmVyeXRoaW5nIHdpbGwgYmUgZnJlZWQgZWl0aGVyIGJ5IG91ciBgZnJl ZV9mdW5jJwogICAgICAgICAgb3IgYnkgc29tZSBvdGhlciBzeW10YWIsIGV4 Y2VwdCBmb3Igb3VyIGxpbmV0YWJsZS4KSW5kZXg6IHN5bXRhYi5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIv c3ltdGFiLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTEyCmRpZmYgLXUg LXAgLXIxLjExMiBzeW10YWIuaAotLS0gc3ltdGFiLmgJNSBGZWIgMjAwOCAy MjoxNzo0MCAtMDAwMAkxLjExMgorKysgc3ltdGFiLmgJMyBBcHIgMjAwOCAx NzozOToxMCAtMDAwMApAQCAtODA5LDcgKzgwOSw2IEBAIHN0cnVjdCBzeW10 YWIKICAgY2hhciAqZGlybmFtZTsKIAogICAvKiBUaGlzIGNvbXBvbmVudCBz YXlzIGhvdyB0byBmcmVlIHRoZSBkYXRhIHdlIHBvaW50IHRvOgotICAgICBm cmVlX2NvbnRlbnRzID0+IGRvIGEgdHJlZSB3YWxrIGFuZCBmcmVlIGVhY2gg b2JqZWN0LgogICAgICBmcmVlX25vdGhpbmcgPT4gZG8gbm90aGluZzsgc29t ZSBvdGhlciBzeW10YWIgd2lsbCBmcmVlCiAgICAgIHRoZSBkYXRhIHRoaXMg b25lIHVzZXMuCiAgICAgIGZyZWVfbGluZXRhYmxlID0+IGZyZWUganVzdCB0 aGUgbGluZXRhYmxlLiAgRklYTUU6IElzIHRoaXMgcmVkdW5kYW50CkBAIC04 MTcsNyArODE2LDcgQEAgc3RydWN0IHN5bXRhYgogCiAgIGVudW0gZnJlZV9j b2RlCiAgIHsKLSAgICBmcmVlX25vdGhpbmcsIGZyZWVfY29udGVudHMsIGZy ZWVfbGluZXRhYmxlCisgICAgZnJlZV9ub3RoaW5nLCBmcmVlX2xpbmV0YWJs ZQogICB9CiAgIGZyZWVfY29kZTsKIAo= ------=_Part_3658_30969975.1207245288943--