From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11285 invoked by alias); 31 Mar 2008 17:34:00 -0000 Received: (qmail 11271 invoked by uid 22791); 31 Mar 2008 17:33:59 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 31 Mar 2008 17:33:24 +0000 Received: from zps37.corp.google.com (zps37.corp.google.com [172.25.146.37]) by smtp-out.google.com with ESMTP id m2VHXKkT023630 for ; Mon, 31 Mar 2008 18:33:20 +0100 Received: from el-out-1112.google.com (elfn30.prod.google.com [10.126.190.30]) by zps37.corp.google.com with ESMTP id m2VHUDN1002684 for ; Mon, 31 Mar 2008 10:33:19 -0700 Received: by el-out-1112.google.com with SMTP id n30so517306elf.10 for ; Mon, 31 Mar 2008 10:33:19 -0700 (PDT) Received: by 10.114.76.1 with SMTP id y1mr10518233waa.38.1206984798917; Mon, 31 Mar 2008 10:33:18 -0700 (PDT) Received: by 10.115.107.18 with HTTP; Mon, 31 Mar 2008 10:33:18 -0700 (PDT) Message-ID: Date: Mon, 31 Mar 2008 18:35:00 -0000 From: "Doug Evans" To: gdb-patches@sourceware.org Subject: Re: [RFA] lmemmem.patch In-Reply-To: <20080330213540.GA2856@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200803241737.m2OHbgC8016762@greed.delorie.com> <200803241758.m2OHwDid017265@greed.delorie.com> <20080324203738.GC29991@ins.uni-bonn.de> <20080324205119.GE29991@ins.uni-bonn.de> <20080324212354.GA16323@caradoc.them.org> <20080330213540.GA2856@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00507.txt.bz2 On Sun, Mar 30, 2008 at 2:35 PM, Daniel Jacobowitz wrote: > Here you go. How does this look? It frees us to rely on gnulib's > stdint.h, string.h, and other useful modules should we want them. I > didn't make gdbserver completely use gnulib, only build memmem; I > tested this on Linux (memmem present) and Windows (memmem missing). > GDB will use the included memmem even on Linux, since glibc's is known > to be slower. Great. [I had to touch Makefile.am before running gnulib-tool and then immediately remove it afterwards. Also, gdbserver/configure.ac needs its copyright year updated.]