On Jan 31, 2008 2:48 PM, Daniel Jacobowitz <drow@false.org> wrote:
> [...]
>
> Can't call value_free here.  That's just a call to free, and values
> are kept in a linked list; see value_release and value_free_to_mark.
> In general, it's fine to leak values unless you're in a loop.  If your
> caller cares, it will use value_free_to_mark to clean up; otherwise it
> will happen at the top level.
>
> value_one has the same issue.

Ah.  Oops.

> No la_unop_result_type in this version (which I like best of the
> several you posted).

Righto.

> Yes, Objective-C also.  Please clarify that "6.7" is a GDB version
> number, or use a date.  Or just change it for all languages;
> documenting "the value system uses C type promotions" is nice and
> simple.  Either way is OK with me.
>
> Beyond that the patch looked OK.

Thanks for the review.
Attached is what I checked in.