Re: [BUG] BINOP_DIV and ptyp command

Daniel Jacobowitz
2008-01-29T13:46:31Z

On Mon, Jan 28, 2008 at 09:34:48PM -0800, Doug Evans wrote:
> On Jan 28, 2008 8:52 PM, Doug Evans <dje@google.com> wrote:
> > [...]
> > So it seems like the following is the correct patch.
>
> Well, not quite. Ok to check the appended patch in?
>
> Changing the expected result to long makes / and % no longer special -
> x*y has an expected result of long.
>
> One can argue it should be int, but any fix for that is orthogonal to
> fixing / and % handling. I think.

If you had to change a testcase to a more wrong answer, then the bug
isn't orthogonal :-) We should be following C promotion rules, and
automatically promoting int math to long is incorrect.

--
Daniel Jacobowitz
CodeSourcery