Re: [BUG] BINOP_DIV and ptyp command

Doug Evans
2008-01-29T05:35:27Z

On Jan 28, 2008 8:52 PM, Doug Evans <dje@google.com> wrote:
> [...]
> So it seems like the following is the correct patch.

Well, not quite. Ok to check the appended patch in?

Changing the expected result to long makes / and % no longer special -
x*y has an expected result of long.

One can argue it should be int, but any fix for that is orthogonal to
fixing / and % handling. I think.

Derived from whatis-exp.exp:

(gdb) whatis x
type = int
(gdb) whatis y
type = int
(gdb) whatis x*y
type = long

2008-01-28 Doug Evans <dje@sebabeach.org>

* eval.c (evaluate_subexp_standard): If DIV/REM/MOD and
EVAL_AVOID_SIDE_EFFECTS, remove special case and process normally.

* gdb.base/whatis-exp.exp: Update expected result of x/y and x%y.

Index: eval.c
===================================================================
RCS file: /cvs/src/src/gdb/eval.c,v
retrieving revision 1.77
diff -u -p -r1.77 eval.c
--- eval.c 18 Jan 2008 17:07:39 -0000 1.77
+++ eval.c 29 Jan 2008 05:27:55 -0000
@@ -1509,9 +1509,6 @@ evaluate_subexp_standard (struct type *e
goto nosideret;
if (binop_user_defined_p (op, arg1, arg2))
return value_x_binop (arg1, arg2, op, OP_NULL, noside);
- else if (noside == EVAL_AVOID_SIDE_EFFECTS
- && (op == BINOP_DIV || op == BINOP_REM || op == BINOP_MOD))
- return value_zero (value_type (arg1), not_lval);
else
return value_binop (arg1, arg2, op);

Index: testsuite/gdb.base/whatis-exp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/whatis-exp.exp,v
retrieving revision 1.7
diff -u -p -r1.7 whatis-exp.exp
--- testsuite/gdb.base/whatis-exp.exp 1 Jan 2008 22:53:19 -0000 1.7
+++ testsuite/gdb.base/whatis-exp.exp 29 Jan 2008 05:27:55 -0000
@@ -139,7 +139,7 @@ gdb_expect {

send_gdb "whatis x/y\n"
gdb_expect {
- -re ".*type = int.*$gdb_prompt $" {
+ -re ".*type = long.*$gdb_prompt $" {
pass "whatis value of x/y"
}
-re ".*$gdb_prompt $" { fail "whatis value of x/y" }
@@ -148,7 +148,7 @@ gdb_expect {

send_gdb "whatis x%y\n"
gdb_expect {
- -re ".*type = int.*$gdb_prompt $" {
+ -re ".*type = long.*$gdb_prompt $" {
pass "whatis value of x%y"
}
-re ".*$gdb_prompt $" { fail "whatis value of x%y" }