From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24772 invoked by alias); 28 Jan 2008 18:15:24 -0000 Received: (qmail 24760 invoked by uid 22791); 28 Jan 2008 18:15:23 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 Jan 2008 18:15:03 +0000 Received: from zps18.corp.google.com (zps18.corp.google.com [172.25.146.18]) by smtp-out.google.com with ESMTP id m0SIEhsJ012110 for ; Mon, 28 Jan 2008 10:14:43 -0800 Received: from wa-out-1112.google.com (wahk34.prod.google.com [10.114.237.34]) by zps18.corp.google.com with ESMTP id m0SICh5B013003 for ; Mon, 28 Jan 2008 10:14:42 -0800 Received: by wa-out-1112.google.com with SMTP id k34so4110922wah.10 for ; Mon, 28 Jan 2008 10:14:42 -0800 (PST) Received: by 10.114.15.1 with SMTP id 1mr4059113wao.27.1201544081283; Mon, 28 Jan 2008 10:14:41 -0800 (PST) Received: by 10.115.107.7 with HTTP; Mon, 28 Jan 2008 10:14:41 -0800 (PST) Message-ID: Date: Mon, 28 Jan 2008 18:17:00 -0000 From: "Doug Evans" To: "GDB Patches" Subject: Re: RFA: patch to fix multi-breakpoint enable/disable handling of inline functions In-Reply-To: <200712272136.04574.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071016001816.F059B1C7E69@localhost> <200712272136.04574.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00649.txt.bz2 Ping ... On Dec 27, 2007 10:36 AM, Vladimir Prus wrote: > > On Tuesday 27 November 2007 02:22:40 Douglas Evans wrote: > > How about this version? > > > > Here I use libiberty/hashtab.c to determine function name ambiguity. > > > > It turns out the bug exists for constructors too. I.e. > > l->function_name for "Derived" in the gdb.cp/mb-ctor testcase is > > "Derived" for both locations. I wonder if for this particular > > situation l->function_name should record an "enhanced" name to > > distinguish them. > > Hi Doug, > sorry for slow reply. I think this version of patch is fine, but > I don't have the right to approve it. > > Speaking about the constructors issue you bring -- right, for > reasons unknown the function name for constructor does not > include parameter types (either in plain text, or mangled). > > Storing mangled name would require two bits: > > 1. Learning how to get than mangled name. > 2. Changing expand_line_sal_maybe to cope with this. > Right now, if you set breakpoint at function name, we first > expand locations, and then check that all newly found locations > belong to a function of the same name. So, if you set a breakpoint > on a specific instantiation of template function that is inline, > you'd have breakpoint on all inlined instances of that instantiations, > but not on other instantiations. > > Now if we use mangled name of constructor, then setting breakpoint on > constructor by name won't set breakpoint on the other constructor. > It might require some tweaks to get right > > - Volodya >