From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25139 invoked by alias); 5 Jan 2008 22:49:54 -0000 Received: (qmail 25131 invoked by uid 22791); 5 Jan 2008 22:49:53 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 05 Jan 2008 22:49:19 +0000 Received: from zps37.corp.google.com (zps37.corp.google.com [172.25.146.37]) by smtp-out.google.com with ESMTP id m05MnFH2007697 for ; Sat, 5 Jan 2008 14:49:15 -0800 Received: from wa-out-1112.google.com (wafj37.prod.google.com [10.114.186.37]) by zps37.corp.google.com with ESMTP id m05MnCgY001572 for ; Sat, 5 Jan 2008 14:49:13 -0800 Received: by wa-out-1112.google.com with SMTP id j37so11684032waf.7 for ; Sat, 05 Jan 2008 14:49:12 -0800 (PST) Received: by 10.114.130.1 with SMTP id c1mr20448840wad.52.1199573352608; Sat, 05 Jan 2008 14:49:12 -0800 (PST) Received: by 10.115.107.7 with HTTP; Sat, 5 Jan 2008 14:49:12 -0800 (PST) Message-ID: Date: Sat, 05 Jan 2008 22:49:00 -0000 From: "Doug Evans" To: gdb-patches@sourceware.org Subject: Re: [RFA] patch for DW_AT_comp_dir/DW_AT_name vs .debug_line inconsistencies Cc: ARistovski@qnx.com In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00092.txt.bz2 [btw, this is my interpretation of Daniel's suggestion, http://sourceware.org/ml/gdb/2008-01/msg00012.html, all gaffes are mine of course] On Jan 5, 2008 2:18 PM, Doug Evans wrote: > Ref: http://sourceware.org/ml/gdb/2008-01/msg00007.html > > [Also ref: http://sourceware.org/ml/gdb-patches/2007-11/msg00314.html > but I'm agnostic as to whether gdb should handle #line like this. The > testcases in this patch use #line for convenience only.] > > How about this? > Aleksandar, does this work for you? [you'll need to still account for > IS_ABSOLUTE_PATH issues I suspect] > > This patch has dwarf_decode_lines prescan the .debug_line info for > files that match DW_AT_name of the main source file, and passes that > to start_subfile instead of what's recorded in .debug_line. This lets > start_subfile get a match with the initial subfile created by > start_symtab. > > I took an easy out in scanning for a match, I just pick the first. I > can add the requisite code if folks think this is the way to go. > > No regressions in the testsuite (i686-linux). >