From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21583 invoked by alias); 5 Jan 2008 22:33:23 -0000 Received: (qmail 21574 invoked by uid 22791); 5 Jan 2008 22:33:22 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 05 Jan 2008 22:33:05 +0000 Received: from zps75.corp.google.com (zps75.corp.google.com [172.25.146.75]) by smtp-out.google.com with ESMTP id m05MWwq4022552 for ; Sat, 5 Jan 2008 22:32:58 GMT Received: from wa-out-1112.google.com (wahj5.prod.google.com [10.114.236.5]) by zps75.corp.google.com with ESMTP id m05MWv9a002835 for ; Sat, 5 Jan 2008 14:32:57 -0800 Received: by wa-out-1112.google.com with SMTP id j5so10486887wah.15 for ; Sat, 05 Jan 2008 14:32:57 -0800 (PST) Received: by 10.114.154.1 with SMTP id b1mr2563753wae.34.1199572377312; Sat, 05 Jan 2008 14:32:57 -0800 (PST) Received: by 10.115.107.7 with HTTP; Sat, 5 Jan 2008 14:32:57 -0800 (PST) Message-ID: Date: Sat, 05 Jan 2008 22:33:00 -0000 From: "Doug Evans" To: gdb-patches@sourceware.org Subject: [RFC] make handling of input path vs subfile path consistent MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_1398_21990197.1199572377307" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00091.txt.bz2 ------=_Part_1398_21990197.1199572377307 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 353 Hi. There's something I don't understand. Why does start_subfile not prepend dirname to name if the latter is not absolute? Since name,dirname are added to the subfile list if there isn't a match and then will later be used to do matches, it seems like we want to prepend dirname to the input name before doing FILENAME_CMP. Am I missing something? ------=_Part_1398_21990197.1199572377307 Content-Type: application/octet-stream; name=gdb-080105-start-subfile-1.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fb2qa8x00 Content-Disposition: attachment; filename=gdb-080105-start-subfile-1.patch Content-length: 2758 MjAwOC0wMS0wNSAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog YnVpbGRzeW0uYyAoc3RhcnRfc3ViZmlsZSk6IFRyZWF0IGlucHV0IG5hbWUg bGlrZSBzdWJmaWxlLT5uYW1lLAoJcHJlcGVuZCB0aGVpciBjb21waWxhdGlv biBkaXJlY3Rvcnkgd2hlbiB0aGV5J3JlIHJlbGF0aXZlIHBhdGhzLgoKSW5k ZXg6IGJ1aWxkc3ltLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9zcmMvc3JjL2dkYi9idWlsZHN5bS5jLHYKcmV0cmlldmluZyBy ZXZpc2lvbiAxLjU5CmRpZmYgLXUgLXAgLXUgLXAgLXIxLjU5IGJ1aWxkc3lt LmMKLS0tIGJ1aWxkc3ltLmMJMSBKYW4gMjAwOCAyMjo1MzowOSAtMDAwMAkx LjU5CisrKyBidWlsZHN5bS5jCTUgSmFuIDIwMDggMjE6MzQ6MzMgLTAwMDAK QEAgLTU4MywzNSArNTgzLDQxIEBAIHZvaWQKIHN0YXJ0X3N1YmZpbGUgKGNo YXIgKm5hbWUsIGNoYXIgKmRpcm5hbWUpCiB7CiAgIHN0cnVjdCBzdWJmaWxl ICpzdWJmaWxlOworICBjaGFyICpjb21wYXJhYmxlX25hbWUgPSBuYW1lOwor CisgIGlmICghIElTX0FCU09MVVRFX1BBVEggKG5hbWUpCisgICAgICAmJiBk aXJuYW1lICE9IE5VTEwpCisgICAgY29tcGFyYWJsZV9uYW1lID0gY29uY2F0 IChkaXJuYW1lLCBTTEFTSF9TVFJJTkcsIG5hbWUsIE5VTEwpOwogCiAgIC8q IFNlZSBpZiB0aGlzIHN1YmZpbGUgaXMgYWxyZWFkeSBrbm93biBhcyBhIHN1 YmZpbGUgb2YgdGhlIGN1cnJlbnQKICAgICAgbWFpbiBzb3VyY2UgZmlsZS4g ICovCiAKICAgZm9yIChzdWJmaWxlID0gc3ViZmlsZXM7IHN1YmZpbGU7IHN1 YmZpbGUgPSBzdWJmaWxlLT5uZXh0KQogICAgIHsKLSAgICAgIGNoYXIgKnN1 YmZpbGVfbmFtZTsKKyAgICAgIGNoYXIgKnN1YmZpbGVfbmFtZSA9IHN1YmZp bGUtPm5hbWU7CiAKLSAgICAgIC8qIElmIE5BTUUgaXMgYW4gYWJzb2x1dGUg cGF0aCwgYW5kIHRoaXMgc3ViZmlsZSBpcyBub3QsIHRoZW4KLQkgYXR0ZW1w dCB0byBjcmVhdGUgYW4gYWJzb2x1dGUgcGF0aCB0byBjb21wYXJlLiAgKi8K LSAgICAgIGlmIChJU19BQlNPTFVURV9QQVRIIChuYW1lKQotCSAgJiYgIUlT X0FCU09MVVRFX1BBVEggKHN1YmZpbGUtPm5hbWUpCisgICAgICAvKiBDb21i aW5lIHN1YmZpbGUncyBuYW1lLCBkaXJuYW1lIGJlZm9yZSBjb21wYXJpbmcu ICAqLworICAgICAgaWYgKCEgSVNfQUJTT0xVVEVfUEFUSCAoc3ViZmlsZS0+ bmFtZSkKIAkgICYmIHN1YmZpbGUtPmRpcm5hbWUgIT0gTlVMTCkKIAlzdWJm aWxlX25hbWUgPSBjb25jYXQgKHN1YmZpbGUtPmRpcm5hbWUsIFNMQVNIX1NU UklORywKIAkJCSAgICAgICBzdWJmaWxlLT5uYW1lLCBOVUxMKTsKLSAgICAg IGVsc2UKLQlzdWJmaWxlX25hbWUgPSBzdWJmaWxlLT5uYW1lOwogCi0gICAg ICBpZiAoRklMRU5BTUVfQ01QIChzdWJmaWxlX25hbWUsIG5hbWUpID09IDAp CisgICAgICBpZiAoRklMRU5BTUVfQ01QIChzdWJmaWxlX25hbWUsIGNvbXBh cmFibGVfbmFtZSkgPT0gMCkKIAl7CiAJICBjdXJyZW50X3N1YmZpbGUgPSBz dWJmaWxlOwogCSAgaWYgKHN1YmZpbGVfbmFtZSAhPSBzdWJmaWxlLT5uYW1l KQogCSAgICB4ZnJlZSAoc3ViZmlsZV9uYW1lKTsKKwkgIGlmIChjb21wYXJh YmxlX25hbWUgIT0gbmFtZSkKKwkgICAgeGZyZWUgKGNvbXBhcmFibGVfbmFt ZSk7CiAJICByZXR1cm47CiAJfQogICAgICAgaWYgKHN1YmZpbGVfbmFtZSAh PSBzdWJmaWxlLT5uYW1lKQogCXhmcmVlIChzdWJmaWxlX25hbWUpOwogICAg IH0KIAorICBpZiAoY29tcGFyYWJsZV9uYW1lICE9IG5hbWUpCisgICAgeGZy ZWUgKGNvbXBhcmFibGVfbmFtZSk7CisKICAgLyogVGhpcyBzdWJmaWxlIGlz IG5vdCBrbm93bi4gIEFkZCBhbiBlbnRyeSBmb3IgaXQuIE1ha2UgYW4gZW50 cnkKICAgICAgZm9yIHRoaXMgc3ViZmlsZSBpbiB0aGUgbGlzdCBvZiBhbGwg c3ViZmlsZXMgb2YgdGhlIGN1cnJlbnQgbWFpbgogICAgICBzb3VyY2UgZmls ZS4gICovCg== ------=_Part_1398_21990197.1199572377307--