From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28646 invoked by alias); 14 Dec 2007 20:49:24 -0000 Received: (qmail 28638 invoked by uid 22791); 14 Dec 2007 20:49:24 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Dec 2007 20:49:15 +0000 Received: from zps18.corp.google.com (zps18.corp.google.com [172.25.146.18]) by smtp-out.google.com with ESMTP id lBEKn7R2002337 for ; Fri, 14 Dec 2007 12:49:13 -0800 Received: from py-out-1112.google.com (pybu52.prod.google.com [10.34.97.52]) by zps18.corp.google.com with ESMTP id lBEKlLQu002357 for ; Fri, 14 Dec 2007 12:49:06 -0800 Received: by py-out-1112.google.com with SMTP id u52so2322386pyb.1 for ; Fri, 14 Dec 2007 12:49:06 -0800 (PST) Received: by 10.141.113.6 with SMTP id q6mr2180870rvm.249.1197665345839; Fri, 14 Dec 2007 12:49:05 -0800 (PST) Received: by 10.141.142.4 with HTTP; Fri, 14 Dec 2007 12:49:05 -0800 (PST) Message-ID: Date: Fri, 14 Dec 2007 21:27:00 -0000 From: "Doug Evans" To: gdb-patches@sourceware.org Subject: Re: [RFA] patch for 2384, dangling TYPE_VPTR_BASETYPE In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071214002920.GA1208@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00200.txt.bz2 One improvement might be to add more comments at the change site to clarify the situation. e.g. when fill_in_vptr_fieldno does useful work and when it doesn't. [assuming fill_in_vptr_fieldno remains ... it's not clear to me whether the ultimate fix will remove it]