From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2911 invoked by alias); 27 Nov 2007 00:11:19 -0000 Received: (qmail 2903 invoked by uid 22791); 27 Nov 2007 00:11:18 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Nov 2007 00:11:11 +0000 Received: from zps37.corp.google.com (zps37.corp.google.com [172.25.146.37]) by smtp-out.google.com with ESMTP id lAR0B8bv015417 for ; Tue, 27 Nov 2007 00:11:08 GMT Received: from rv-out-0910.google.com (rvbk15.prod.google.com [10.140.87.15]) by zps37.corp.google.com with ESMTP id lAR0AZDi015572 for ; Mon, 26 Nov 2007 16:11:07 -0800 Received: by rv-out-0910.google.com with SMTP id k15so736529rvb for ; Mon, 26 Nov 2007 16:11:07 -0800 (PST) Received: by 10.114.198.1 with SMTP id v1mr2237waf.1196122266114; Mon, 26 Nov 2007 16:11:06 -0800 (PST) Received: by 10.115.107.7 with HTTP; Mon, 26 Nov 2007 16:11:06 -0800 (PST) Message-ID: Date: Tue, 27 Nov 2007 00:11:00 -0000 From: "Douglas Evans" To: gdb-patches@sourceware.org Subject: Re: RFC: example fix to pr 2360 In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00497.txt.bz2 On Nov 15, 2007 3:55 PM, Douglas Evans wrote: > To make things more concrete to what I was refering to in > http://sourceware.org/ml/gdb/2007-11/msg00138.html I've filed pr 2360, > and attached is an example fix. > > I'm not sufficiently happy with it that I'd submit it RFA, but that's > mostly because of perceived objections to the use of xfullpath. Maybe > the thing to do is write a canonicalizer like what is done in > cli-cmds.c:cd_command (and presumably move it to a more generic > place). > > Suggestions? Ping. One use case that xfullpath might not always handle properly is if the binary is used on a different host than it was compiled on and the path name doesn't exist. In this case one would still want the path name canonicalized but xfullpath won't work. Is there anything I'm missing? TIA