From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16907 invoked by alias); 14 Nov 2007 21:53:44 -0000 Received: (qmail 16897 invoked by uid 22791); 14 Nov 2007 21:53:44 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 14 Nov 2007 21:53:42 +0000 Received: from zps37.corp.google.com (zps37.corp.google.com [172.25.146.37]) by smtp-out.google.com with ESMTP id lAELrbIF025005 for ; Wed, 14 Nov 2007 13:53:37 -0800 Received: from ug-out-1314.google.com (ugdt39.prod.google.com [10.66.146.39]) by zps37.corp.google.com with ESMTP id lAELrVLj029398 for ; Wed, 14 Nov 2007 13:53:37 -0800 Received: by ug-out-1314.google.com with SMTP id t39so393684ugd for ; Wed, 14 Nov 2007 13:53:36 -0800 (PST) Received: by 10.66.243.13 with SMTP id q13mr225656ugh.1195077213659; Wed, 14 Nov 2007 13:53:33 -0800 (PST) Received: by 10.67.21.14 with HTTP; Wed, 14 Nov 2007 13:53:33 -0800 (PST) Message-ID: Date: Wed, 14 Nov 2007 21:53:00 -0000 From: "Douglas Evans" To: gdb-patches@sourceware.org Subject: RFA: fix start_subfile, start_symtab argument descriptions MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00284.txt.bz2 On the gdb list I wrote: > 1) [...] then comp_dir should not be > passed as the dirname argument to start_subfile in dwarf2read.c I did some more reading and understand things better now. Ok to check in? This just fixes the description of the DIRNAME argument to start_subfile and adds descriptions of the arguments to start_symtab. I didn't include a ChangeLog entry in this particular case since it's just comment fixes. I can certainly provide one if you want it checked in with one. Index: buildsym.c =================================================================== RCS file: /cvs/src/src/gdb/buildsym.c,v retrieving revision 1.55 diff -u -p -r1.55 buildsym.c --- buildsym.c 5 Nov 2007 18:06:10 -0000 1.55 +++ buildsym.c 14 Nov 2007 21:45:45 -0000 @@ -507,7 +507,7 @@ make_blockvector (struct objfile *objfil /* Start recording information about source code that came from an included (or otherwise merged-in) source file with a different name. NAME is the name of the file (cannot be NULL), DIRNAME is - the directory in which it resides (or NULL if not known). */ + the directory in which the file was compiled (or NULL if not known). */ void start_subfile (char *name, char *dirname) @@ -778,12 +778,15 @@ compare_line_numbers (const void *ln1p, /* Start a new symtab for a new source file. Called, for example, when a stabs symbol of type N_SO is seen, or when a DWARF TAG_compile_unit DIE is seen. It indicates the start of data for - one original source file. */ + one original source file. + + NAME is the name of the file (cannot be NULL). DIRNAME is the directory in + which the file was compiled (or NULL if not known). START_ADDR is the + lowest address of objects in the file (or 0 if not known). */ void start_symtab (char *name, char *dirname, CORE_ADDR start_addr) { - last_source_file = name; last_source_start_addr = start_addr; file_symbols = NULL;