Ping. I've split the patch into two parts, separating out the tweaks to mb-templates.exp,mb-ctor.exp (I'll send this in a separate message). I also fixed a few typos. The revised patch is attached. Ok to check in? On 10/15/07, Doug Evans wrote: > Consider: > > dje@ruffy:~/gnu/sourceware/head/obj/gdb/testsuite/gdb.cp$ ~/gnu/sourceware/head/rel/bin/gdb mb-inline > GNU gdb 6.7.50-20071009-cvs > Copyright (C) 2007 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. Type "show copying" > and "show warranty" for details. > This GDB was configured as "i386-linux"... > Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1". > (gdb) b mb-inline.h:6 > Breakpoint 1 at 0x80483e9: file ../../../src/gdb/testsuite/gdb.cp/mb-inline.h, line 6. (2 locations) > (gdb) i b > Num Type Disp Enb Address What > 1 breakpoint keep y > 1.1 y 0x080483e9 in foo > at ../../../src/gdb/testsuite/gdb.cp/mb-inline.h:6 > 1.2 y 0x0804843d in foo > at ../../../src/gdb/testsuite/gdb.cp/mb-inline.h:6 > (gdb) dis 1.2 > (gdb) i b > Num Type Disp Enb Address What > 1 breakpoint keep y > 1.1 y 0x080483e9 in foo > at ../../../src/gdb/testsuite/gdb.cp/mb-inline.h:6 > 1.2 n 0x0804843d in foo > at ../../../src/gdb/testsuite/gdb.cp/mb-inline.h:6 > (gdb) r > Starting program: /home/dje/gnu/sourceware/head/obj/gdb/testsuite/gdb.cp/mb-inline > > Breakpoint 1, foo (i=1) at ../../../src/gdb/testsuite/gdb.cp/mb-inline.h:6 > 6 return i; // set breakpoint here > (gdb) i b > Num Type Disp Enb Address What > 1 breakpoint keep y > breakpoint already hit 1 time > 1.1 n 0x080483e9 in foo > at ../../../src/gdb/testsuite/gdb.cp/mb-inline.h:6 > 1.2 y 0x0804843d in foo > at ../../../src/gdb/testsuite/gdb.cp/mb-inline.h:6 > (gdb) > > Note that 1.1 is now disabled and 1.2 is enabled. > > Here's a patch. > There is a heuristic involved in knowing when to not compare function names. > I've tried to come up with something reasonable.