From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jtUKA1JI/GVQXRAAWB0awg (envelope-from ) for ; Thu, 21 Mar 2024 10:46:42 -0400 Received: by simark.ca (Postfix, from userid 112) id EE3E01E0C0; Thu, 21 Mar 2024 10:46:41 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DD1631E030 for ; Thu, 21 Mar 2024 10:46:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 92CF63858428 for ; Thu, 21 Mar 2024 14:46:39 +0000 (GMT) Received: from re-prd-fep-048.btinternet.com (mailomta23-re.btinternet.com [213.120.69.116]) by sourceware.org (Postfix) with ESMTPS id 80D023858CD1 for ; Thu, 21 Mar 2024 14:45:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 80D023858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dronecode.org.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 80D023858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=213.120.69.116 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711032338; cv=none; b=lER6y3HkhtAz0jwf0hdHQgnIe+nkUz0zWJVHqOAKLYFIF3l0GK+ib0LpgD/mPSgQFh+HoQLF0dowGutGvUeiDDXsaNjNGkdl5eL88DjO3zGCZg4d422zsTiuL7IVY5DNB6EFv8fdUMMHq75fdXkfVW4HdSnRgv0Xvh93zT2kY7c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711032338; c=relaxed/simple; bh=b1ucjeRgAlWmr9VGrd/tEivnNFQYlG71QkRy1A+DLiw=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=HZdF2OmAm7dJmBo6VDw4znxyHQFkTpWEVW9cX7utvCEasF0Xpk6GEfU6PRjsBwjzUQR1JibW28eshLklTkfiXrzSyafxyG2Xq7NapYMKNMiiUKjL03FvxgAm6Fu47uv2LDb916B8/xirW6ibLVddXo1bRZ4/Soo0e923Ptw3Du0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from re-prd-rgout-003.btmx-prd.synchronoss.net ([10.2.54.6]) by re-prd-fep-048.btinternet.com with ESMTP id <20240321144535.HWOM17945.re-prd-fep-048.btinternet.com@re-prd-rgout-003.btmx-prd.synchronoss.net>; Thu, 21 Mar 2024 14:45:35 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6577B7320C037BDF X-Originating-IP: [81.129.146.224] X-OWM-Source-IP: 81.129.146.224 X-OWM-Env-Sender: jon.turney@dronecode.org.uk X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvledrleejgddtiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfesthejredttddvjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepffduuddtleelheehiefhvdeghfeguedujeeufeeljedujeegheehlefgieekkeejnecuffhomhgrihhnpehsohhurhgtvgifrghrvgdrohhrghenucfkphepkedurdduvdelrddugeeirddvvdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdelngdpihhnvghtpeekuddruddvledrudegiedrvddvgedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepghgusgdqphgrthgthhgvshesshhouhhrtggvfigrrhgvrdhorhhgpdhrtghpthhtohepohhrghgrughssehgmhgrihhlrdgtohhmpdhrvghvkffrpehhohhsthekuddquddvledqudegiedqvddvgedrrhgrnhhgvgekuddquddvledrsghttggvnhhtrhgrlhhplhhushdrtghomhdprghuthhhpghushgv rhepjhhonhhtuhhrnhgvhiessghtihhnthgvrhhnvghtrdgtohhmpdhgvghokffrpefiuedpoffvtefjohhstheprhgvqdhprhguqdhrghhouhhtqddttdef X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.109] (81.129.146.224) by re-prd-rgout-003.btmx-prd.synchronoss.net (authenticated as jonturney@btinternet.com) id 6577B7320C037BDF; Thu, 21 Mar 2024 14:45:35 +0000 Message-ID: Date: Thu, 21 Mar 2024 14:45:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Better handling for realpath() failures in windows_make_so() on Cygwin To: Orgad Shaneh , gdb-patches@sourceware.org References: <20240321065417.1125-1-orgad.shaneh@audiocodes.com> Content-Language: en-US From: Jon Turney In-Reply-To: <20240321065417.1125-1-orgad.shaneh@audiocodes.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 21/03/2024 06:53, Orgad Shaneh wrote: > From: Jon Turney Not sure where this is coming from, but this doesn't seem to be my latest version of this patch. > Fix a memory leak which would occur in the case when the result of realpath() is > greater than or equal to SO_NAME_MAX_PATH_SIZE. > > Distinguish between realpath() failing (returning NULL), and returning a path > longer than SO_NAME_MAX_PATH_SIZE > > Warn rather than stopping with an error in those cases. This line in the patch commentary, and the title, refers to the part of the patch submitted [1], which is already applied as commit a0e9b53238c3033222c53b1654da535c0743ab6e. I separated that out because of the discussion starting at [2] ("Remove SO_NAME_PATH_SIZE instead"...) [1] https://sourceware.org/pipermail/gdb-patches/2020-January/164695.html [2] https://sourceware.org/pipermail/gdb-patches/2016-January/130435.html