Re: [PATCH 00/12] More type macros removal

Simon Marchi
2020-07-13T03:15:55Z

On 2020-07-06 9:38 a.m., Simon Marchi wrote:
> Here is the next installment of removal of type macros, in favor of
> getter/setter methods.
>
> I added some assertions in some of these methods, to verify that the
> method is called on a type with the expected code (this is one of the
> goal of these changes). It found one case that needed to be fixed,
> handled by patch 3.
>
> The rest should be relatively straightforward.
>
> Simon Marchi (12):
> gdb: add type::bounds / type::set_bounds
> gdb: remove TYPE_RANGE_DATA macro
> gdb: make get_discrete_bounds check for non-constant range bounds
> gdb: add accessors to struct dynamic_prop
> gdb: remove TYPE_HIGH_BOUND and TYPE_LOW_BOUND
> gdb: remove TYPE_LOW_BOUND_UNDEFINED and TYPE_HIGH_BOUND_UNDEFINED
> gdb: remove TYPE_LOW_BOUND_KIND and TYPE_HIGH_BOUND_KIND
> gdb: remove TYPE_ARRAY_{UPPER,LOWER}_BOUND_IS_UNDEFINED
> gdb: remove TYPE_ARRAY_{LOWER,UPPER}_BOUND_VALUE
> gdb: remove TYPE_BIT_STRIDE
> gdb: remove TYPE_ARRAY_BIT_STRIDE
> gdb: make type::bounds work for array and string types
>
> gdb/ada-lang.c | 22 ++--
> gdb/ada-tasks.c | 7 +-
> gdb/ada-typeprint.c | 8 +-
> gdb/ada-valprint.c | 2 +-
> gdb/c-typeprint.c | 4 +-
> gdb/c-varobj.c | 18 ++-
> gdb/compile/compile-c-symbols.c | 6 +-
> gdb/compile/compile-c-types.c | 10 +-
> gdb/compile/compile-cplus-types.c | 10 +-
> gdb/ctfread.c | 2 +-
> gdb/dwarf2/loc.c | 16 +--
> gdb/dwarf2/read.c | 71 +++++-------
> gdb/eval.c | 8 +-
> gdb/f-typeprint.c | 4 +-
> gdb/f-valprint.c | 10 +-
> gdb/gdbtypes.c | 186 +++++++++++++-----------------
> gdb/gdbtypes.h | 162 +++++++++++++++++++-------
> gdb/gnu-v3-abi.c | 3 +-
> gdb/guile/scm-type.c | 7 +-
> gdb/m2-typeprint.c | 20 ++--
> gdb/m2-valprint.c | 4 +-
> gdb/mdebugread.c | 8 +-
> gdb/p-typeprint.c | 10 +-
> gdb/p-valprint.c | 2 +-
> gdb/printcmd.c | 3 +-
> gdb/python/py-type.c | 7 +-
> gdb/rust-lang.c | 8 +-
> gdb/type-stack.c | 3 +-
> gdb/valarith.c | 11 +-
> gdb/valops.c | 2 +-
> gdb/value.c | 4 +-
> 31 files changed, 337 insertions(+), 301 deletions(-)
>
> --
> 2.27.0
>

I pushed this.

Simon