From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qKs7Am01YWcqLx4AWB0awg (envelope-from ) for ; Tue, 17 Dec 2024 03:25:17 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=ExtPKvef; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 05E1A1E097; Tue, 17 Dec 2024 03:25:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9E1711E05C for ; Tue, 17 Dec 2024 03:25:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 577423858C48 for ; Tue, 17 Dec 2024 08:25:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 577423858C48 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=ExtPKvef Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by sourceware.org (Postfix) with ESMTPS id CA3653858429 for ; Tue, 17 Dec 2024 08:19:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA3653858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA3653858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734423554; cv=none; b=gOnpWgGViR+J3h0N7s1sq1FGatQEiMB+RS89OOIckeSpafyiyw3bVJr6yR0h/GEzdh0/+Q/gfWNm94Dzl2rq52g5KvEiSHoDcusCAEeQpKrw1/ZjfN1Wt9rWqelXlUFnxPJAzHQgXwrGWiBxtbT7o2bn4SZwbNx7HOr4/TSCvgM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734423554; c=relaxed/simple; bh=shTTFd/PT13W2jUei6Eq3FsY+M5AU98N4W2IOyX2iY8=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=aIbjdjznNusRmijAfPrMvEFhvuUbiPOmcdWgTs6Gmf5dCEZjCP81jqBrNGg0WLYurfDr4+qsnPL7YYQOXP+vd/JlCAcjtipKYRCbVAl3IDzhGGfe45FPAsDY4JTl6ZasUpsX26MK+Opl0ZK6lNfBTrLjtuRgo5KYq4i7GFaB2o4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA3653858429 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734423554; x=1765959554; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=shTTFd/PT13W2jUei6Eq3FsY+M5AU98N4W2IOyX2iY8=; b=ExtPKvefhm1c1bKItMQvulF42DHGzXVdTcdI0wqcIpwjYE+RHJXSC12K dP6lX3f5HaATHTApGphTafjY7af8wt7ukq1ELhsmDYm1TRIA5UYhd0YuB Azk2JxC/iawCq1UW9mjqLlK8Ic+h4oU248Enq0/rvn2nDN4idNUlIt1n6 Mz9frqrCPXaL9onbeq62iHs2ntZHg7Ysco84tkkIG5GXWT+IRlCpeGk3C OqVQnpo7yzcRxUgYgh/py65q3Zf/FR2FGZMajFpOrzxnWn5EpcDO09Ad8 6l0jQH18V6zjJTaQxDXoIBO54+e2OXJWa0n0LezYJ/YBts5L0SQ0ZDhBH A==; X-CSE-ConnectionGUID: vuwimYRrQhiW3szIBAioSQ== X-CSE-MsgGUID: GdF+1CnqR9qP5t3LyZMhKA== X-IronPort-AV: E=McAfee;i="6700,10204,11288"; a="34160397" X-IronPort-AV: E=Sophos;i="6.12,241,1728975600"; d="scan'208";a="34160397" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2024 00:19:13 -0800 X-CSE-ConnectionGUID: bUPuvHDKQ9iyNjaQ40bndQ== X-CSE-MsgGUID: nGTZt0EqR66AjawIjSCgcA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,241,1728975600"; d="scan'208";a="128278732" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2024 00:19:11 -0800 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Cc: simon.marchi@efficios.com Subject: [PUSHED 5/8] gdbserver: boolify regcache fields Date: Tue, 17 Dec 2024 09:18:27 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The registers_valid and registers_owned fields of the regcache struct are of type int. Make them bool. Approved-By: Simon Marchi --- gdbserver/regcache.cc | 12 ++++++------ gdbserver/regcache.h | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc index 4a064f6374b..93bf5988a33 100644 --- a/gdbserver/regcache.cc +++ b/gdbserver/regcache.cc @@ -46,7 +46,7 @@ get_thread_regcache (thread_info *thread, bool fetch) thread->set_regcache (regcache); } - if (fetch && regcache->registers_valid == 0) + if (fetch && !regcache->registers_valid) { scoped_restore_current_thread restore_thread; @@ -55,7 +55,7 @@ get_thread_regcache (thread_info *thread, bool fetch) memset (regcache->register_status, REG_UNAVAILABLE, regcache->tdesc->reg_defs.size ()); fetch_inferior_registers (regcache, -1); - regcache->registers_valid = 1; + regcache->registers_valid = true; } return regcache; @@ -85,7 +85,7 @@ regcache_invalidate_thread (thread_info *thread) store_inferior_registers (regcache, -1); } - regcache->registers_valid = 0; + regcache->registers_valid = false; } /* See regcache.h. */ @@ -127,7 +127,7 @@ init_register_cache (struct regcache *regcache, regcache->tdesc = tdesc; regcache->registers = (unsigned char *) xcalloc (1, tdesc->registers_size); - regcache->registers_owned = 1; + regcache->registers_owned = true; regcache->register_status = (unsigned char *) xmalloc (tdesc->reg_defs.size ()); memset ((void *) regcache->register_status, REG_UNAVAILABLE, @@ -140,13 +140,13 @@ init_register_cache (struct regcache *regcache, { regcache->tdesc = tdesc; regcache->registers = regbuf; - regcache->registers_owned = 0; + regcache->registers_owned = false; #ifndef IN_PROCESS_AGENT regcache->register_status = NULL; #endif } - regcache->registers_valid = 0; + regcache->registers_valid = false; return regcache; } diff --git a/gdbserver/regcache.h b/gdbserver/regcache.h index db3b2425de6..c2e8e141d13 100644 --- a/gdbserver/regcache.h +++ b/gdbserver/regcache.h @@ -38,8 +38,8 @@ struct regcache : public reg_buffer_common register cache is _not_ pass-through, unlike GDB's. Note that "valid" here is unrelated to whether the registers are available in a traceframe. For that, check REGISTER_STATUS below. */ - int registers_valid = 0; - int registers_owned = 0; + bool registers_valid = false; + bool registers_owned = false; unsigned char *registers = nullptr; #ifndef IN_PROCESS_AGENT /* One of REG_UNAVAILABLE or REG_VALID. */ -- 2.34.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928