From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JcgwH5q5vWo2MCEAWB0awg (envelope-from ) for ; Wed, 30 Sep 2026 21:38:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1790818714; bh=VwX6C94OOWjJjbs1x0dRC2+A9mMV4qH6l6W8+ogW/lI=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IqouoDhBE5j0UgM5DsnEohZmncgGgDYUobT3W2Ii5enVQA910QAcGuofl5X++jz6H W2ZbqMz7aiu5C8UIZBtPIKBKDt9aaGc6DfOYP6arSSBW6nT/itzxsDLmWp2M6Rq0oD j0mG7lCwGmcHx/gQ5+017NOxfUuzibHoIITisU5M= Received: by simark.ca (Postfix, from userid 112) id 68F991E051; Wed, 30 Sep 2026 21:38:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=DmMEHOS/; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 98B7A1E01F for ; Wed, 30 Sep 2026 21:38:33 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 17ECE4BB58A3 for ; Thu, 1 Oct 2026 01:38:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 17ECE4BB58A3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=DmMEHOS/ Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BEA164BB3BE7 for ; Thu, 1 Oct 2026 01:38:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BEA164BB3BE7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BEA164BB3BE7 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790818689; cv=none; b=wfzlOcE7STUzTtWLN4hvmHSW2EoQYDF+80At6ezDasRqWj+6BG6iIXUYF3+v00NtDIB6QXHkbZSlffRwHjtUJ1CtNXLmnQhqLBwPPJU/LTHyy3KpwdQdIYYyoKs3DSVA+JOV797qKDxiXoU+x7nItj4KR45i9ZZhCguIvh9OnWc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790818689; c=relaxed/simple; bh=VwX6C94OOWjJjbs1x0dRC2+A9mMV4qH6l6W8+ogW/lI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=sR5HdL9d2Dq6mKzqGGaJVGPVV0GPx6iI5jreWuzUmsYgm+iE6mZeQr/jR3dOHrDbI1Y4z9Kf6yl5qmU6nCZDu+xZjMYQFy1Dre1HWGlNjHJLdmwPrGdFYPKE8DxWuUOdi1dxC4oFLmQZJm/XrLggp9qPchzYIEapUyWX6b8ws28= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=DmMEHOS/ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BEA164BB3BE7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1790818689; bh=VwX6C94OOWjJjbs1x0dRC2+A9mMV4qH6l6W8+ogW/lI=; h=Date:Subject:To:References:From:In-Reply-To:From; b=DmMEHOS/Un+QuRPOYsj+97Idqwa13KBX/DkTSkIXaj+2Zf6pRyRgAU2XK5qfwykPi v/bYfmbMi5vDpPT3TaqbFAYretTHLinBSQsmOSV58ewTvEfI4+7INTP1LVjLw1pJDd KLoESHToJI2vHSlcFCqyjaqsCd+TJxK4D32MC2VI= Received: by simark.ca (Postfix) id 36DA71E01F; Wed, 30 Sep 2026 21:38:08 -0400 (EDT) Message-ID: Date: Wed, 30 Sep 2026 21:38:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 9/9] gdb: fix some comments in global_symbol_searcher To: "Rohr, Stephan" , Simon Marchi , "gdb-patches@sourceware.org" References: <20260929194119.155169-1-simon.marchi@efficios.com> <20260929194119.155169-10-simon.marchi@efficios.com> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-09-30 10:01, Rohr, Stephan wrote: > We could fix the comment regarding "RESULTS_SET" I mentioned in > patch #8 feedback in this patch. In the same comment in symtab.h for methods > "add_matching_symbols" and "add_matching_msymbols" we also have > "MAX_SEARCH_RESULTS" vs. "M_MAX_SEARCH_RESULTS". Which one is correct? > We could use this patch for proper alignment. Ok, I included the RESULT_SET fix in this patch. It would be M_MAX_SEARCH_RESULTS nowadays. Simon