On 24-09-19 22:06, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> [gdb/tdep] Handle mxcsr kernel bug on Intel Skylake CPUs > > Tom> gdb/ChangeLog: > > Tom> 2019-09-24 Tom de Vries > > Tom> PR gdb/23815 > Tom> * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers): > Tom> Initialize xstateregs before ptrace PTRACE_GETREGSET call. > > Thanks for the patch. > > I think this is reasonable, but it could use a comment before the memset > explaining why it is there. Maybe some future gdb hacker will want to > remove the memset, and a comment would explain why not to, or when it > would be ok to. Hi Tom, thanks for the review. Added comment and committed as below. Thanks, - Tom