From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26489 invoked by alias); 1 Feb 2017 11:11:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26480 invoked by uid 89); 1 Feb 2017 11:11:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS,URIBL_RED autolearn=no version=3.3.2 spammy=Mention, Hx-languages-length:928, H*M:0809 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Feb 2017 11:11:14 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4F55F8553F; Wed, 1 Feb 2017 11:11:14 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v11BBDlS020133; Wed, 1 Feb 2017 06:11:13 -0500 Subject: Re: [PATCH 2/2] [BZ 21005] Add support for Intel 64 rdrand and rdseed record/replay To: Luis Machado , gdb-patches@sourceware.org References: <1485451129-16439-1-git-send-email-lgustavo@codesourcery.com> <1485451129-16439-2-git-send-email-lgustavo@codesourcery.com> From: Pedro Alves Message-ID: Date: Wed, 01 Feb 2017 11:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1485451129-16439-2-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00016.txt.bz2 On 01/26/2017 05:18 PM, Luis Machado wrote: > The following patch addresses BZ 21005, which is gdb failing to > recognize an rdrand instruction. Suggest saying "this patch". "following" won't make sense when this sentence is part of the git log history. > [....] I thought we > had arch-specific tests in testsuite/, but it looks like we don't exercise > every little instruction with record/replay, so no testcase. Let me know > if one is required. This remark looks out of date? > > OK? Please remember to remove this, as it doesn't make sense to have it in a commit log. > > gdb/ChangeLog > > 2017-01-26 Luis Machado > > * NEWS: Mention support for record/replay of Intel 64 rdrand and > rdseed instructions. > i386-tdep.c (i386_process_record): Handle Intel 64 rdrand and rseed. OK. Thanks, Pedro Alves