From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id DF0BF388B010 for ; Mon, 1 Jun 2020 13:26:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DF0BF388B010 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-trNpGRmtOciY4p9t6-9cYw-1; Mon, 01 Jun 2020 09:26:18 -0400 X-MC-Unique: trNpGRmtOciY4p9t6-9cYw-1 Received: by mail-wr1-f72.google.com with SMTP id c14so4874405wrm.15 for ; Mon, 01 Jun 2020 06:26:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+EZ6juwO5k48iTYDh/X8avmmvg6CoXoHEWZVuL3sOvg=; b=bdsog/SiQklYBvtHPolwa0bKXpjWPwOQiZ3y+I1F7QcYnN1TaDsqiJsF7cjejT/OBw TBTBhmVwDtgjxXixICJXvLwczjxmGYZE1JmJxDleiY+eudqUbLw2pHbVVBYl8icBjamu xeVDsSz9k4Kt1Mm/+eGFjurXyDsguixeRpHwqoUFM2H4NOWQkDh+lRjn6KBEJI2hyPXV GX0bA5GXudyscMEFTAZXlEnMMW1vIvLYuKZvojfEWyVnngBtoMH0bPzxUH7OodP14OCX lh3IclDxfqBZaCFW6BKxjWDwsZV0DRL1EIU963o1FEEuWGCfjy+9wa4D1Q5UpiDhZZ19 97vQ== X-Gm-Message-State: AOAM530uQ6PsaB2Fpj3cRog39K89EVUEo/WAYVd4pFK3CbOOyLNSnjLM OVpODqKv+RLYFuk4DRyRtsb7Myo3nXxLpJO1oIdpwJ4xQIqxi5jXumLM6hLlpppUEvrubzkPEnU RTb9HWUHIVXeiTx99dVwc2Q== X-Received: by 2002:adf:9d8e:: with SMTP id p14mr21286854wre.236.1591017977013; Mon, 01 Jun 2020 06:26:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnz2koOtl19dBJ/LXIm3lXy3GM6bgBROUGGaIGwSRA30R4P/IPPjI6eWBjOB+tJMJsdK3uvw== X-Received: by 2002:adf:9d8e:: with SMTP id p14mr21286839wre.236.1591017976818; Mon, 01 Jun 2020 06:26:16 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id i10sm5091247wrw.51.2020.06.01.06.26.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2020 06:26:16 -0700 (PDT) Subject: Re: [PATCH 2/2] gdb: Add support for tracking the DWARF line table is-stmt field To: Bernd Edlinger , Andrew Burgess References: <94e33268f64060fc887670f4ee5ed524050cbcc7.1580902412.git.andrew.burgess@embecosm.com> <20200211135710.GR4020@embecosm.com> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: Date: Mon, 1 Jun 2020 14:26:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 13:26:21 -0000 On 3/5/20 6:01 PM, Bernd Edlinger wrote: > Hmm, I think this got stuck, so I just worked a follow-up patch out for you. > > I also noticed that the test case cannot work with gcc before gcc-8, > since the is_stmt feature is not implemented earlier, at least with > gcc-4.8 and gcc-5.4 the test case fails. > > I thought it would be good to detect that by adding the -gstatement-frontiers > option, so that the gcc driver complains when it is not able to generate > sufficient debug info for that test. Won't this prevent the test from running with Clang? (and likely other compilers?) Thanks, Pedro Alves