From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lQeOGt3WEmB2dAAAWB0awg (envelope-from ) for ; Thu, 28 Jan 2021 10:23:09 -0500 Received: by simark.ca (Postfix, from userid 112) id 5D6CC1EF80; Thu, 28 Jan 2021 10:23:09 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 59C171E945 for ; Thu, 28 Jan 2021 10:23:08 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ECB2F3850401; Thu, 28 Jan 2021 15:23:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ECB2F3850401 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611847388; bh=LWJjT0FSMMC5kuCWPzoNSeXDERsXee0PJq/0L4qDr7Y=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=crdwcW544/cafMG1pIWBDhGOj20FL6f79FXRYlGI6tf9VzDohQb+e+yvGi1DXv1Of TTozipoFOl5d4LnlWyeZsNs9Yh9ham9C/cFPkZ+AnRVW7NEhny8+w8+v6KXX25a3se dyAH7Edi8S9ShbHdTl/FD3rT4oW1zMEh6K2ILaj0= Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2070.outbound.protection.outlook.com [40.107.244.70]) by sourceware.org (Postfix) with ESMTPS id 422753851416 for ; Thu, 28 Jan 2021 15:23:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 422753851416 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QrroJfHSa4kBZxL+Pc0hDmDFE69qv8xj/N5Z51iBpnDkCbo0iJvDQaD49Excus9tbVeECZab74XDQSoC13ZjDtRoChs0w2b/kmuM/XJiP8l9zj0Bqq2rEdt8JJ4X3NL5FCAJqz3R00AY1CYQgVx36haGaATXmQXpF2xsOK6IR4fmoPfz7qu3CuPOZcto1V0u+osDX5Urwd2MpJ1BtLsEo2H9rTTtg+nyqXHV7KUcPd+M2aeR5E9sCDpHY+MZiGLZ+rLAeYF/zxv83CaD0WRn4ywc7gxp0AxZ0yyg3QEE+NfyoLfXh4NgsOEEi/JCZno+3Rll92Y7MH3IMsM0Ie8qAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LWJjT0FSMMC5kuCWPzoNSeXDERsXee0PJq/0L4qDr7Y=; b=XdymB0qNyyYnJd30j5jmNqNqOYP2grV4mwhIBnEQ/6ezIin+4O58JMMxknUXPeJvLgDEy2+XUg0KqGSEOBxQmv4LgstzGR0pR3yLaI4xe1nxCa2S+TOiQbQgYfIxRTnCOifZWSJGD07nKlSxOz9wEzGz1Lspzvb6Vx5dFmuO8PyIYUUZOGJtqlQGK9NgJO7ENBmFtt5qzKZgxFmB+DTRIElc3gmQKTb51r8KgH9NFx5M4LzXblWwPm3wwc7p0rGrubiRHezdaGcjIq4ooGIUyza96cS8BAArCVOKympDJY2Gr+rKEUFThSsqNf/RwZuuPrLdp7NFzbYdcpABdEyYcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB3897.namprd12.prod.outlook.com (2603:10b6:5:1ca::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.19; Thu, 28 Jan 2021 15:22:58 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3763.019; Thu, 28 Jan 2021 15:22:58 +0000 Subject: Re: [PATCH 02/13] gdb/dwarf: fix bound check in read_rnglist_index To: Simon Marchi , gdb-patches@sourceware.org References: <20210120053925.142862-1-simon.marchi@polymtl.ca> <20210120053925.142862-3-simon.marchi@polymtl.ca> Message-ID: Date: Thu, 28 Jan 2021 15:22:53 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 In-Reply-To: <20210120053925.142862-3-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:cf:c92a:a445:6f68] X-ClientProxiedBy: AM4PR0701CA0003.eurprd07.prod.outlook.com (2603:10a6:200:42::13) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:cf:c92a:a445:6f68] (2a00:23c7:5a85:6801:cf:c92a:a445:6f68) by AM4PR0701CA0003.eurprd07.prod.outlook.com (2603:10a6:200:42::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.8 via Frontend Transport; Thu, 28 Jan 2021 15:22:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: cb6cd859-5b0f-4a43-2aeb-08d8c3a09807 X-MS-TrafficTypeDiagnostic: DM6PR12MB3897: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y44gPJZt5pYkeVI9RA9SRch+Ttt+C3OHlJSr1o6mjHnnl5pfPetGTRnBMQv5xxErsj4eQDllHIc99T9qKCIbwvfAA4BdDHdA2yFVFRdLOrObp4RHH71Mmw+DVjwKQctKyp0zdawnstPVqRS9ZNRq7nFB8MGJtuwmDpq2Kpe7/cPE/rLbbjvAVcU5bxuXMEeMCUJ8LBwc9J6Wdrgk0jztMhNrJrpr6pjS+Ak4+DtNX399Kk5S1QjCsl39ye/ODdg9Mwnrw3Wo6bW1kDsTfzFmq99dBCBz+CCkqh4QHf0eTxKHYUQG/XXzc485UJkCTl6d2rPFb4zzNHQCwL1qcS0ckUKAy0AzdLnzJnwdHJueI/A37WLzroZ4r8kAfG0Zmhuk2kKCy/WdQvBpOvISS4wQ5+dn/LvEsaD52ad5GOXcrCPCK510pCJyHCJ/yMF1TmwY9BUS7V8uV2pZ+6cSVBh+ZxVZkNX1NF0kj9jWvi7hMkwD6wOY84SprCFxFFXEz+YA/qWCFItErGWwNbJovZNvEVXSjP4QHx0BTmx5e76IyQcNWfGB0/RWmATgUaKQnsCUjLdtXFrWET9Uww8Fk6OG0extjjFwa8rZfYxnvNqKdxo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(346002)(136003)(376002)(366004)(83380400001)(66946007)(86362001)(66556008)(66476007)(31696002)(36756003)(31686004)(316002)(8936002)(4744005)(52116002)(478600001)(2906002)(16526019)(6486002)(8676002)(5660300002)(4326008)(186003)(6666004)(2616005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?OTZHSjJ0SlhGTTR2cWZZeWMxdFNMcWdZUGJONkNPL1dJRWE3RUxIQnp4ZWFD?= =?utf-8?B?dk8xSkVkL2x6aWVjMytnWERNaGdsVXZTUFNpZHhzK3hmU0doVHpYUTJpNnpD?= =?utf-8?B?MHNMT2tta2d5bzVpVlRmc0ZYNCtuQ3ZLTGdQRlRycDZURDZPMzRNYTE1U29O?= =?utf-8?B?WTM0WkJ5VU5rY2hWZjFkV2I3RzdNdEhieVNOYjV5Y1BpejJzWnBiVjJ3OS8z?= =?utf-8?B?cnRxWXM4Y3UzYUN1NHl6bzJoKy8rRnR0dllTNTdVbElsckpCaGorbFc3ZXdi?= =?utf-8?B?elM2dHZZSCtBYmlIeWJQMHVuelkrNnFGL2dDQUI0QWZZMWFkNysrWGpFUDIy?= =?utf-8?B?eFV1ZGhFWW9pY0ZyNmx5UXdEL01nWDhmTzZLV0tjaVEvK3ZsQ3ExektQb0dV?= =?utf-8?B?QVJoeTVvS2RpaE5NQXVvUjE5KzRPSDFicVVhR1M3dTUrLzVPUTFxTzJ6Sy9R?= =?utf-8?B?Ujl4emU0QkhHQmJvbVp0bGlzb3F2T2JVR1QrVUVDSWoxMWJHR0RVeEswOG1E?= =?utf-8?B?N25NRmtlTFVJL3hYTjE0UU5OMkRUYnVQcmg1YlJvVW93ckVhRHpSYjEyKzZa?= =?utf-8?B?eUVTZFRLdmxHSTFiZjJOeGhRSFRJa083ZEJudCtZVjlhc2N5YUNtVTZrZlZD?= =?utf-8?B?d1dNN1pLYThoMXhneXBuMXNMalN1RWcvTDR1QlVzMUxvRDNUakl3SGNWMXVr?= =?utf-8?B?WFZTcGhyTkpPQ2h1VnorU2FQT1dPK2kyaGhXTDVKUmdReHBzTWZzelptbHA5?= =?utf-8?B?STBxK0VDU3daUnRuMExSZzQrTlR1N1QwVHZKMmF4YjJlNkE5dWR5UjFYakx3?= =?utf-8?B?YnIzS3I3VXYrZHNML2pCaHFoT1ZuUkRuckN2ODFQMEkxdGVLbTZScWIxZVVI?= =?utf-8?B?eFR0NWZLbDFwdDJQTjBlU2xLODJNck9LS1NDT21oS2JiUGVIdWQzRTdmYTFx?= =?utf-8?B?U1ZweU15VWtHZmhaUjMycVdaelN6aTZ4RC9qRXpyMzExM3dtZUlpVGpzczBW?= =?utf-8?B?Q1A1YXEzUlVPUEpIZ0V3RW4ybjBmdVVKT1JRUUFpTXRzc3l4b2c3TVU0NWJ6?= =?utf-8?B?N0Jxcm5IZ2JQeVlKc3R3VGtzNjRFRGpUWWJPaXpqV0ExRW9NclNmbS8zRm9m?= =?utf-8?B?Vi9XNTlGTDBqeXVvR2k2eXhYQVN3QjFvQ3h3NHB2WTJIYUdjNkk3V2RoL3Vk?= =?utf-8?B?NnZEdXN0ZzlFZ3RZUVdxblpZNTFFSG9wQkxBc01aZU1uNWVzLyt0OTJBa2Za?= =?utf-8?B?QXZvbVYwVEs3L3BFNmtoc0dWeGFXZk9kcVk4RUc2bHBIcVVoaWlud08yR2hx?= =?utf-8?B?S0VSTDFGWGs2Sms3aGZEbHRWaEpSVis1TU1Kb1pUdGxkOHhiV0dOSXpqOHg5?= =?utf-8?B?OGV5SmhUeVRncndCZ2ZETDc1dndONlIwWmFDUFN4S2tTSUFONzJKNU1MSGd6?= =?utf-8?B?MTF6c3lhc0N5L2JJUWlxOXptdEpPTUF6dGR6VmwvUVVFT1h4VmZkb2VmN1VW?= =?utf-8?Q?xlwrSeW54WHq45xnGQUQXTUL8xy?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb6cd859-5b0f-4a43-2aeb-08d8c3a09807 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2021 15:22:58.7074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Oo5wSMXLyRSLXx7SAtIfw0OOXP/hxQ4YPJZlEWjGJgU7MYDHi/2UNqsq6PFaImvmHfBAP9PpUVtg3yI/X2Akog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3897 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Cc: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > From: Simon Marchi > > I think this check in read_rnglist_index is wrong: > > /* Validate that reading won't go beyond the end of the section. */ > if (start_offset + cu->header.offset_size > rnglist_base + section->size) > error (_("Reading DW_FORM_rnglistx index beyond end of" > ".debug_rnglists section [in module %s]"), > objfile_name (objfile)); > > The addition `rnglist_base + section->size` doesn't make sense. > rnglist_base is an offset into `section`, so it doesn't make sense to > add it to `section`'s size. `start_offset` also is an offset into > `section`, so we should just compare it to just `section->size`. Completely agree with this change.