From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mCHzL0OTsl/SYQAAWB0awg (envelope-from ) for ; Mon, 16 Nov 2020 09:57:07 -0500 Received: by simark.ca (Postfix, from userid 112) id BE3301F08B; Mon, 16 Nov 2020 09:57:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 729AE1E552 for ; Mon, 16 Nov 2020 09:57:07 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 08BC03851C33; Mon, 16 Nov 2020 14:57:07 +0000 (GMT) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by sourceware.org (Postfix) with ESMTPS id B8E063851C33 for ; Mon, 16 Nov 2020 14:57:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B8E063851C33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f65.google.com with SMTP id l1so18987296wrb.9 for ; Mon, 16 Nov 2020 06:57:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=a6pdcHtJ1FoxytkJ8ndUkFDW4RoJ0GAGS3k9ROz1Hf4=; b=LcM0cCQBN2xBy2H+q74xEDIl4kaaio6IaQ83XflRvlHrcUszWABeN7b4Kg8nXWPSX9 ymHO4uk5+xkBY3s82JQHSmPu/MVw0PjKFyQRjzeCgwdwwwZrrDQgT6R8hGYdhK9E5wJr xdBD846zDmzQysokvsjiTvCZaCA1RLnb+iIT/GL386zcr/zW0XjuTVFGGfZgujAyrl0g R/hv/7MM3WIkhmdEWgx/T4SWN3cflsIoe7ubbC1+SppgqgDbKE+3iv57UEd3b4v02k6O RzUcA2ekkmUC3/wX35zDBVN6LQOQVoSoDZAj0IFTIPSAXvR1P+RPV+FlMEyjUwGz8MEd foUQ== X-Gm-Message-State: AOAM533oZB946RhxZuSrGfjQ5aRhFhfg5OOTYiCTnwm5q9Zb24yaSbia InU7ITIB7p1RNAsE4KDLslkLHq/G6LjRLA== X-Google-Smtp-Source: ABdhPJzGx8KOW/6zNmI2Y7v9c7ILsjwNGeX7fTX5amACsBBVCyxBf9s/PxMdrglF3sqKbmalBkC/wA== X-Received: by 2002:a5d:4984:: with SMTP id r4mr20545971wrq.191.1605538623312; Mon, 16 Nov 2020 06:57:03 -0800 (PST) Received: from ?IPv6:2001:8a0:f91f:e900:1d90:d745:3c32:c159? ([2001:8a0:f91f:e900:1d90:d745:3c32:c159]) by smtp.gmail.com with ESMTPSA id u14sm20206921wrq.93.2020.11.16.06.57.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Nov 2020 06:57:02 -0800 (PST) Subject: Re: [PATCH] Fix frame cycle detection (Re: [PATCH 3/3] Make scoped_restore_current_thread's cdtors exception free (RFC)) To: Tom de Vries , "Aktemur, Tankut Baris" , Simon Marchi , "gdb-patches@sourceware.org" References: <20200708233125.1030-1-pedro@palves.net> <20200708233125.1030-4-pedro@palves.net> <58a4020f-fbbb-611f-eb23-c1b3fa25d4f2@simark.ca> <39ad8351-3f99-1162-4d2f-b5dbee5756f8@simark.ca> <47b34393-3833-bb85-84dc-9a8bde3e1a77@palves.net> <3293dbc2-922a-8589-dbc7-75ebd5a26175@simark.ca> <7e4c3794-99fa-72fb-21be-26e0787495fc@palves.net> <6d50a9a2-5c37-9709-9c51-a2161c517b35@suse.de> From: Pedro Alves Message-ID: Date: Mon, 16 Nov 2020 14:57:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <6d50a9a2-5c37-9709-9c51-a2161c517b35@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 11/16/20 1:48 PM, Tom de Vries wrote: > On 11/9/20 3:05 PM, Aktemur, Tankut Baris via Gdb-patches wrote: >> On Saturday, October 31, 2020 3:35 PM, Pedro Alves wrote: >>> On 10/30/20 11:32 AM, Pedro Alves wrote: >>>> Hi! >>>> >>>> On 10/30/20 7:44 AM, Aktemur, Tankut Baris wrote: >>>> >>>>> Hi Pedro, >>>>> >>>>> This patch created the regression below: >>>>> >>>>> Breakpoint 1, 0x00000000004012bb in eh2 (/gdb-up/gdb/frame.c:641: internal-error: >>> frame_id get_frame_id(frame_info*): Assertion `stashed' failed. >>>>> A problem internal to GDB has been detected, >>>>> further debugging may prove unreliable. >>>>> Quit this debugging session? (y or n) FAIL: gdb.base/eh_return.exp: hit breakpoint (GDB >>> internal error) >>>> >>>> Hmm, sorry about that. It passes for me on the machine I was >>>> running tests on, so I missed it. I can reproduce it on a F27 machine. >>>> I'll take a better look. >>>> >>> >>> Here's a fix. See explanation within. >> >> Thanks. This fixed the regression. >> > > I can also confirm that this fixes the FAIL for me. Glad I committed > that test-case :) Indeed. :-) Thanks for the confirmations. I've merged this now. Pedro Alves