Re: [PATCH] Add a timeout parameter to gdb_do_one_event

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2022-07-22 18:45, Patrick Monnerat wrote:
> 
> On 7/22/22 15:41, Simon Marchi wrote:
>>
>> On 2022-03-17 09:08, Patrick Monnerat via Gdb-patches wrote:
>>> Since commit b2d8657, having a per-interpreter event/command loop is not
>>> possible anymore.
>>>
>>> As Insight uses a GUI that has its own event loop, gdb and GUI event
>>> loops have then to be "merged" (i.e.: work together). But this is
>>> problematic as gdb_do_one_event is not aware of this alternate event
>>> loop and thus may wait forever.
>>>
>>> The solution is to implement a wait timeout to gdb_do_one_event. This
>>> cannot be done externally as gdb timers are event sources themselves.
>>>
>>> The new parameter defaults to "no timeout": as it is used by Insight
>>> only, there is no need to update calls from the gdb source tree.
> Hi Simon,
>> Sorry for the delay.
> Never mind!
>> The patch is fine with me.  Pedro and Tom also
>> took a look at previous iterations and I didn't see any disagreement
>> either.
> Thanks to you and mates for these reviews and advice.
>> I don't remember, do you have push access?  Otherwise I can
>> push it for you.
> 
> No, I haven't. That's why I'm pinging many times!
> 
> Thanks in advance for commit.
> 
> BTW: would it be possible to get push access ? How ? I still have some patches (all related to insight) to submit and want to speed up a bit the process (without skipping this list, of course!) and discharge you from this task.

Totally, fill the form here: https://sourceware.org/cgi-bin/pdw/ps_form.cgi

You can put me as the referrer.  Once you have your push access, you can
push a patch adding yourself to gdb/MAINTAINERS.  See the git history of
that file for examples.  You can then push the patch in this thread.

Simon