From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QB2+EU7m/WPLeAAAWB0awg (envelope-from ) for ; Tue, 28 Feb 2023 06:32:30 -0500 Received: by simark.ca (Postfix, from userid 112) id 460301E222; Tue, 28 Feb 2023 06:32:30 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=CQFBzeU4; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D11231E128 for ; Tue, 28 Feb 2023 06:32:29 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 84E4E3857BB3 for ; Tue, 28 Feb 2023 11:32:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84E4E3857BB3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677583949; bh=TYzSRzRTkDHELmW0IsRy873PV+2s8m5mEY/j7geawb8=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=CQFBzeU4ovnLkZJpaDVpKuIScoRN4+hU77hBBBjEpmU/DqkmIg89rCarFEF7msb/C TxANM8qVdCLwSr4H2h5JHpb1oAEzpKE3P8MQjOqm9AJ6OSbDcLMkPoEXUSmrpsjGaP 8oDjtvwYmwlIUqnyDo/u1Gc3Bm03e3o5M9hcBx1g= Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by sourceware.org (Postfix) with ESMTPS id 347C03850229 for ; Tue, 28 Feb 2023 11:30:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 347C03850229 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="313785167" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="313785167" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:30:52 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="623992214" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="623992214" Received: from ultl2604.iul.intel.com (HELO localhost) ([172.28.48.47]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:30:51 -0800 To: gdb-patches@sourceware.org Subject: [PATCH 20/26] gdbserver: make some regcache fields private Date: Tue, 28 Feb 2023 12:28:18 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tankut Baris Aktemur via Gdb-patches Reply-To: Tankut Baris Aktemur Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Some fields of the regcache struct are used for internal state tracking. Prevent direct access to them from outside by making them private. --- gdbserver/regcache.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gdbserver/regcache.h b/gdbserver/regcache.h index ad71a9acaec..be412bc3765 100644 --- a/gdbserver/regcache.h +++ b/gdbserver/regcache.h @@ -36,6 +36,8 @@ struct regcache : public reg_buffer_common /* Back-link to the thread to which this regcache belongs. */ thread_info *thread = nullptr; +private: + /* Whether the REGISTERS buffer's contents are fetched. If false, we haven't fetched the registers from the target yet. Note that this register cache is _not_ pass-through, unlike GDB's. Also, @@ -49,6 +51,8 @@ struct regcache : public reg_buffer_common /* See gdbsupport/common-regcache.h. */ enum register_status *register_status = nullptr; +public: + /* Constructors. */ regcache () = default; regcache (const target_desc *tdesc); @@ -59,6 +63,8 @@ struct regcache : public reg_buffer_common virtual ~regcache (); #endif +public: + /* Init the regcache data. */ void initialize (const target_desc *tdesc, unsigned char *regbuf); -- 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928