From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78123 invoked by alias); 24 Feb 2020 20:39:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78114 invoked by uid 89); 24 Feb 2020 20:39:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:e34uDo_, H*i:CAJDtP-TqxS, H*f:CAJDtP-TqxS, H*f:sk:e34uDo_ X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Feb 2020 20:39:48 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id DA5021E5FA; Mon, 24 Feb 2020 15:39:46 -0500 (EST) Subject: Re: [PATCH v4] Add debuginfod support to GDB To: Aaron Merey Cc: gdb-patches@sourceware.org, Tom Tromey References: <1282d65e-5c1c-a7d8-b29d-24dd8036ae2d@simark.ca> From: Simon Marchi Message-ID: Date: Mon, 24 Feb 2020 20:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2020-02/txt/msg00931.txt.bz2 On 2020-02-23 11:42 p.m., Aaron Merey wrote: > On Fri, Feb 21, 2020 at 3:12 PM Simon Marchi wrote: >> I'll have to build debuginfod and configure it, so I can give it a try >> and see how it files. >> >> In the mean time: if we fail to parse the server's response as a bfd or >> if the build id doesn't match, I think we need to display a warning, >> because it probably means that the server sent us something bad, or there >> was some problem somewhere in the pipeline. >> >> Currently, if that happens, the user would see "Download successful", but >> no debug info loaded, so it's a bit misleading. > > I added the warnings but removed the "Download successful" anyway > since it resulted in too much noise. > > Aaron > I just noticed that the debuginfod_debuginfo_query definition is not in sync with the declaration, so when we build without debug info support, we get: CXX debuginfod-support.o /home/smarchi/src/binutils-gdb/gdb/debuginfod-support.c: In function ‘scoped_fd debuginfod_debuginfo_query(const unsigned char*, int, gdb::unique_xmalloc_ptr*)’: /home/smarchi/src/binutils-gdb/gdb/debuginfod-support.c:36:1: error: no previous declaration for ‘scoped_fd debuginfod_debuginfo_query(const unsigned char*, int, gdb::unique_xmalloc _ptr*)’ [-Werror=missing-declarations] debuginfod_debuginfo_query (const unsigned char *build_id __attribute__((unused)), ^~~~~~~~~~~~~~~~~~~~~~~~~~ I also think you could remove the __attribute__((unused)). We don't use -Wunused-parameter in GDB, and I don't think we plan to (there are a ton of places with unused parameters like that, that don't hurt). Simon