From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CPnCHU8lCmj5PAMAWB0awg (envelope-from ) for ; Thu, 24 Apr 2025 07:49:35 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gFrYx3T+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 764751E0C3; Thu, 24 Apr 2025 07:49:35 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DFC511E0C0 for ; Thu, 24 Apr 2025 07:49:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8AD6E3858CD1 for ; Thu, 24 Apr 2025 11:49:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8AD6E3858CD1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gFrYx3T+ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 684BD3858D21 for ; Thu, 24 Apr 2025 11:49:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 684BD3858D21 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 684BD3858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745495341; cv=none; b=LVVbOsvCLjUC65Y1RGmSOp8nmNlPTBnjDam+N4qlev+FrwPlw8FziBw07fq1m7OlVLQtR9m76h+qkl0+oEew5B0KF+xSfWomK2FES++rUPynI5Qk+8V4GsKV34JQ4BC0N6x94ZZ6mxrORuX8b42Vc4M4s0J4/7FPLi5kBFKBYwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745495341; c=relaxed/simple; bh=KlGhWRpJuFnFfrqcS26irsusKbOEbT+nwrCYq+BViNY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kmsYSklJvrH5OXR6ZpbtLE0JCyTRLHh3GNBuN5nJBFt+PVfPB8ppExjKQcV9W+po/1fv1hoEyYYNkuScyX/A3FgReIUuKz4ylNX/nv7Y8C166HnaGzNrXnp1p10uzVIBn4HSMZyJuDIQ8emehU5p2utNpTLtxo56CwWOK5V1w2s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 684BD3858D21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745495341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j5h4xGjGJhVNDB+5PRiHCraXgZj8SurSU0UwKXzO/h4=; b=gFrYx3T+OIndn20AQ4C1XBAuD13n8B3CygGDFmopsGYMDP4bsN0dnJTmcekk6FvwwPtvQi jxKcZWZiWzCDxuHba3ykkXkwzgFM/t302csleR1KRRZrpJFnuXlVIvH5aBxamMYsMd4lPd C+iIerIVuMqI0uvOWn9P/8QFt/PaWHY= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-422-GFV8uj4ANBOzJOp_HLR8xg-1; Thu, 24 Apr 2025 07:48:59 -0400 X-MC-Unique: GFV8uj4ANBOzJOp_HLR8xg-1 X-Mimecast-MFC-AGG-ID: GFV8uj4ANBOzJOp_HLR8xg_1745495339 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-736b22717f1so1276518b3a.1 for ; Thu, 24 Apr 2025 04:48:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745495338; x=1746100138; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j5h4xGjGJhVNDB+5PRiHCraXgZj8SurSU0UwKXzO/h4=; b=rIHM3z9GK3bcbPjxX6w9Ocp7T5VQJoynkUSaN4qL/8Vxvud+ayL42KwspyjhIbWMGb d1+fzlpwjn3C1HW7fFaKwIl8wO9WGdr1114fjZBmxfCDhcBj+5/ci52bmYUko3BMGvBb clQBQCwvMlSVw0xE203514ES4MItx4Z+ORKhOFG0gSosrTCq3rKzuMWYMPcMv61w7vyG oXQwgDo39DVMC4EKqUFHkH61Dm66/8ve63WyjjT8hRW0WTjklrH+qqjt7RwdVArDuwMU 7HfZtaYgbihOaXtgMwfKYZGrd8fOyBldKxpdO2b/X3WWtwsh86wvjom97F5f9uvuMp5N hX0g== X-Gm-Message-State: AOJu0YyYiom7tfjqWOc0VfE91g0akfr/Q2s9oJztnfmKcVYw5sU9o6LO fLnvvoSmF8rJXd32Wd1fKWZrBj+IO6ECV2q0KXc/BHD01ADbXYx+NPxPfZjXZgTCfp6WLptWU/9 ES4xQPQH3YqQJUaRhXjXgE5eFb/y6uHVEElah3k0FxczUI3qV1MUm4B44mpGjSI+MXGcw/sq1YX R/ARgGJgoBEPOGHdqO430ZJYWtEyu8aYSFbin2dpLCnAl2 X-Gm-Gg: ASbGnctsKYT2WKDABq3Pra5IjNUjPYKBUu/JR4eRHWX8gCK+kMLBBbU+cMMS69SFAen 9Vj7cMvwcL9AR69RUr1IecMbVMEv8lmr5tQdtaNBL/RExtgUW1bhF/pTcAdtztkOl5FLp2qIv8y wT3QW7EKj+iYOJt/91mEWYewLkBGhS421UquVCGPjoPGyH+0L+maIR9Hf/wvZD8kI4oGsdgWGaZ EUTa8x/ZvPagDVhpoVxJfhzb+AyrhYcswvJF20OgiWx+93Dl+indtikOVkRyrG0oqIyTop381R1 dmD9IfZzUZ0O9HQzby5c4OY= X-Received: by 2002:a05:6a20:d04e:b0:1fe:8f7c:c8e with SMTP id adf61e73a8af0-20445f54bf2mr2783846637.15.1745495338610; Thu, 24 Apr 2025 04:48:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+EpCa5NQGXmQkd2E4Phj6nSW9GUu1bCnAcsq3WFemXsGC9p2pNdJ+S2Qm6bfNI/ZYTzUISA== X-Received: by 2002:a05:6a20:d04e:b0:1fe:8f7c:c8e with SMTP id adf61e73a8af0-20445f54bf2mr2783823637.15.1745495338228; Thu, 24 Apr 2025 04:48:58 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1001? ([2804:14d:8084:9a69::1001]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b15f7fb7e54sm1015200a12.30.2025.04.24.04.48.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 04:48:57 -0700 (PDT) Message-ID: Date: Thu, 24 Apr 2025 08:48:55 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: fix 32 bit build To: gdb-patches@sourceware.org References: <20250424114743.1776473-1-guinevere@redhat.com> From: Guinevere Larsen In-Reply-To: <20250424114743.1776473-1-guinevere@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: y8VJJ1n9spNt2tQq6xhZtMCnbliItROiokp_WcybBHQ_1745495339 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/24/25 8:47 AM, Guinevere Larsen wrote: > The recent commit dbbb9cfd3708a5b09b449c6cbc4d74dfec13904d added a > message using %ld to print an std::vector::size, which is of size_t > type. on 64 bit machines, size_t will be an unsigned long int, making > %ld work just fine, but on 32 bit ones, size_t will be unsigned int, > which causes build to fail. > > This commit fixes that by using %zu instead. After sending the email I realized I forgot the bug trailer. I'll add Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32901 locally > --- > gdb/solib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/solib.c b/gdb/solib.c > index 5c5cfbdd9b9..85ec6bb2f1e 100644 > --- a/gdb/solib.c > +++ b/gdb/solib.c > @@ -1230,7 +1230,7 @@ info_linker_namespace_command (const char *pattern, int from_tty) > break; > } > uiout->message > - (_ ("There are %ld libraries loaded in linker namespace [[%d]]\n"), > + (_ ("There are %zu libraries loaded in linker namespace [[%d]]\n"), > solibs_to_print.size (), ns); > uiout->message > (_ ("Displaying libraries for linker namespace [[%d]]:\n"), ns); > > base-commit: 8c8e5b1f1abfbce913783da0f1cd1f85c60bd445 -- Cheers, Guinevere Larsen She/Her/Hers