From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39176 invoked by alias); 13 Oct 2016 22:03:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39158 invoked by uid 89); 13 Oct 2016 22:03:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Oct 2016 22:03:12 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2B09C8553E; Thu, 13 Oct 2016 22:03:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9DM39Hg025338; Thu, 13 Oct 2016 18:03:10 -0400 Subject: Re: [RFA v2 01/17] Use RAII to save and restore scalars To: Tom Tromey , gdb-patches@sourceware.org References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-2-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: Date: Thu, 13 Oct 2016 22:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1476393012-29987-2-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00410.txt.bz2 On 10/13/2016 10:09 PM, Tom Tromey wrote: > This patch replaces many (but not all) uses of > make_cleanup_restore_integer with a simple RAII-based template class. > It also removes the similar restore_execution_direction cleanup in > favor of this new class. Subsequent patches will replace other > similar cleanups with this class. > > The class is typically instantiated using make_scoped_restore. This > allows for template argument deduction. > > 2016-10-13 Tom Tromey > > * common/scoped_restore.h: New file. > * utils.h: Include scoped_restore.h. > * top.c (execute_command_to_string): Use scoped_restore. > * python/python.c (python_interactive_command): Use > scoped_restore. > (python_command, execute_gdb_command): Likewise. > * printcmd.c (do_one_display): Use scoped_restore. > * mi/mi-main.c (exec_continue): Use scoped_restore. > * mi/mi-cmd-var.c (mi_cmd_var_assign): Use scoped_restore. > * linux-fork.c (checkpoint_command): Use scoped_restore. > * infrun.c (restore_execution_direction): Remove. > (fetch_inferior_event): Use scoped_restore. > * compile/compile.c (compile_file_command): Use > scoped_restore. > (compile_code_command, compile_print_command): Likewise. > * cli/cli-script.c (execute_user_command): Use > scoped_restore. > (while_command, if_command, script_from_file): Likewise. > * arm-tdep.c (arm_insert_single_step_breakpoint): Use > scoped_restore. Great. This is OK and can go in immediately. Thanks, Pedro Alves