From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83548 invoked by alias); 6 Apr 2017 15:05:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83299 invoked by uid 89); 6 Apr 2017 15:05:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=fancy X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Apr 2017 15:05:51 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BD7D27FD50; Thu, 6 Apr 2017 15:05:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BD7D27FD50 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com BD7D27FD50 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 23D097E21B; Thu, 6 Apr 2017 15:05:50 +0000 (UTC) Subject: Re: [PATCH, GDB] Fix Windows gdb build failure with python support To: Thomas Preudhomme , gdb-patches@sourceware.org References: From: Pedro Alves Message-ID: Date: Thu, 06 Apr 2017 15:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00146.txt.bz2 On 04/06/2017 03:28 PM, Thomas Preudhomme wrote: > > > GDB fails to build for Windows host with python support enabled due to Uppercase "Python", and would be a good idea to mention that this is Python 2. > python_file's second argument It's actually PyFile_FromString's second parameter, not python_file's. "python_file" is a reference that is being initialized from the result of PyFile_FromString. > being of type char * and being passed a > string litteral. Typo "literal". > This patch takes the conservative assumptions that the > function might indeed modify the character string and use a local char > array to pass the mode instead. The Python API is notoriously buggy wrt to const-correctness when it comes to string parameters. Note that in gdb/python/python-internal.h, we have fixups for all of: PyObject_GetAttrString PyObject_HasAttrString PyObject_CallMethod PyErr_NewException PySys_GetObject PySys_SetPath PyGetSetDef PyArg_ParseTupleAndKeywords Over the years it's been getting better. A few of those were added just yesterday, but I didn't build Windows with Python so I missed this one. Now, this API in particular seems to have been removed completely in Python 3, so there's no "it was fixed in 3.x" that we could put in a comment. Anyway, since this is just one single place, let's just not bother with anything fancy. Please just add a cast instead (and update the commit log accordingly): PyFile_FromString (full_path.get (), (char *) "r") OK with that change. Thanks, Pedro Alves