Re: [PATCH 25/40] Introduce lookup_name_info and generalize Ada's FULL/WILD name matching

Pedro Alves
2017-11-08T16:10:26Z

On 11/01/2017 03:38 PM, Joel Brobecker wrote:
> Hi Pedro,
>
>> This patch touches the Ada code a good deal. It's main goal is
>> to generalize Ada's FULL/WILD name matching, so that C++ can do
>> something very similar. Let me know if you'd like to review it.
>> I've been holding on moving forward with this
>> series because this is a central patch on top of which the
>> rest of the series sits on.
>
> Thanks for drawing my attention to this patch. Overall, it looks
> pretty neat :) and it starts a nice simplification of some of
> the code in ada-lang. Thank you! I admit I didn't read the patch
> in complete details, but enough to understand how it works and
> convince myself that it should actually work. I've also run it
> through our testsuites and found no regressions, neither with
> this patch, nor the series as a whole.
>
> So, to summarize, this looks good to me!

Phew! I admit that I was worried about your internal
testsuites. :-)

Thanks much, I've pushed this one in now (along with a few of the
follow ups, but not the whole series yet).

Thanks,
Pedro Alves