From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69123 invoked by alias); 10 Apr 2017 03:13:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65953 invoked by uid 89); 10 Apr 2017 03:13:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Apr 2017 03:13:35 +0000 Received: by simark.ca (Postfix, from userid 33) id 302EC1E7F5; Sun, 9 Apr 2017 23:13:35 -0400 (EDT) To: Tom Tromey Subject: Re: [RFA 04/14] Introduce gdb_dlopen_up X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 10 Apr 2017 03:13:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <20170408201208.2672-5-tom@tromey.com> References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-5-tom@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00221.txt.bz2 On 2017-04-08 16:11, Tom Tromey wrote: > This introduces gdb_dlopen_up, a unique_ptr that can close a dlopen'd > library. All the functions working with dlopen handles are updated to > use this new type. > > I did not try to build this on Windows. Well, apparently the build on Windows was broken by the guy that pushed the ptid patch last week, can you believe it? With that fixed (pushing a the fix in a moment) and your patch, it builds fine with --host=x86_64-w64-mingw32. Otherwise, LGTM. Thanks, Simon