From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IX+OIg7xgGmEmyQAWB0awg (envelope-from ) for ; Mon, 02 Feb 2026 13:46:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1770057998; bh=KejjGB/xTFJniZPp1/q0zjF6xs/VF5xusq83E+cK/gM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=koZELmKG5itLFF805dNE8c2gz6NO3c/2cKQ5t+W9ho/sfdj5RnzrHqyEL2dGeA2Zz ANgY+dK90KOBQVYQYNiHfcC6SrRgLozhy2bDtNJNrZ1JQ6Xxb8pqYHVCqrO43X6R5j i0b9F4QK5h5Wu6cBEvKlLRldiY3kXQpZaNRDj/uw= Received: by simark.ca (Postfix, from userid 112) id 8795E1E08D; Mon, 02 Feb 2026 13:46:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=AItX01jL; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E175E1E08D for ; Mon, 02 Feb 2026 13:46:37 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 604254BB58F4 for ; Mon, 2 Feb 2026 18:46:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 604254BB58F4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=AItX01jL Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 966BF4BB58D4 for ; Mon, 2 Feb 2026 18:45:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 966BF4BB58D4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 966BF4BB58D4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770057957; cv=none; b=ZLKBniyJNwpYS6a7JS1UVlUoN31V9LiRFYD92f/tLD/fp0+6QMDuM/unuH/j7+TeUebVmu2mM3iHMi55Ryc8gtQrpL7yaSMFHHH+zXQmJAbhsMKJNud6pOTxfNoRXZkU9vEE9fl9g4PaFU9R6gMiLQtzFsQj3hdSJuZhmsUtHno= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770057957; c=relaxed/simple; bh=KejjGB/xTFJniZPp1/q0zjF6xs/VF5xusq83E+cK/gM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=DcDcaRyvP8Pk5tHDp4tVGXbdg0tIgxUV+IZb7qxKlvExR7miVe53vn6c2l8izpCKjg0eO0uAAHogBaWSBBU+YmXMrBDjrlTTtJBltPHe9lHak3Ral8ok9HzfxpojgCVM4FHo3BOGYeLwK4zCA80fyS2br6pu4NG9JZv1drQyEeA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 966BF4BB58D4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1770057956; bh=KejjGB/xTFJniZPp1/q0zjF6xs/VF5xusq83E+cK/gM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AItX01jLzLG4nlHcCNn/7yZdfANPzjD9XoAOhXUwGmfCa/N127kAcBkyyRrk/QisV +R24ki9jwRMNHT4jpcDaYDpqBxr65LIWkYt01Zifc5HGIz3//FEwGyK3ox7Ca03fGt gGFXufWLncHm+anfOmWHgjE3l7OI/V3Vuuq0oIQ4= Received: by simark.ca (Postfix) id 866E41E08D; Mon, 02 Feb 2026 13:45:56 -0500 (EST) Message-ID: Date: Mon, 2 Feb 2026 13:45:56 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: ensure bp_location::section is set correct to avoid an assert To: "Rohr, Stephan" , Andrew Burgess , =?UTF-8?Q?S=C3=A9bastien_Darche?= Cc: "gdb-patches@sourceware.org" References: <7febb0c1-7bbd-45d5-8ebe-91c34bb4a6ce@efficios.com> <87tt0qe7qf.fsf@redhat.com> <87ldm2dxcl.fsf@redhat.com> <6c31b667-db2d-453e-9597-9fe011c4766e@efficios.com> <87jz186xhv.fsf@redhat.com> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-02-02 03:49, Rohr, Stephan wrote: > Hi all, > > I came across the same issue when debugging a remote inferior that is compiled w/o debug symbols and a > breakpoint is inserted based on the function name that is called in the inferior. > > Our test started to regress with the introduction of patch > "gdb: ensure bp_location::section is set correct to avoid an assert". As mentioned in the patch above, > GDB uses the default gdbarch to insert the breakpoint if the section is NULL. This causes issues later. > > I applied the patch; our breakpoint insertion issue is fixed with this patch. I reviewed the patch, it is > reasonable to me. Only thing I wonder is the usage of 'find_pc_ovelay'; this always returns NULL if > overlay debugging is not used? But I guess that's fixed by using 'find_pc_section' in this case. > > Thanks for working on this, Andrew! I had forgotten about this patch, I think we solved the ROCm issue at another level, with: [PATCH 0/4] make it the responsibility of a symtab_and_line's creator to set its section https://inbox.sourceware.org/gdb-patches/20251024162929.352719-1-sdarche@efficios.com/ Andrew, could you send an updated version of your patch? It doesn't apply anymore, and I think it would deserve not being buried in that other patch's big thread. Simon