From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110120 invoked by alias); 26 Sep 2017 12:12:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109275 invoked by uid 89); 26 Sep 2017 12:12:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Sep 2017 12:12:15 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0FA15356E1; Tue, 26 Sep 2017 12:12:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0FA15356E1 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CDCC69579; Tue, 26 Sep 2017 12:12:13 +0000 (UTC) Subject: Re: [RFA 01/67] Add add_cmd function overloads To: Tom Tromey References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-2-tom@tromey.com> <87a81mghp2.fsf@tromey.com> <87tvzuf2bg.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 26 Sep 2017 12:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87tvzuf2bg.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00792.txt.bz2 On 09/23/2017 05:48 AM, Tom Tromey wrote: > --- a/gdb/command.h > +++ b/gdb/command.h > @@ -117,6 +117,7 @@ var_types; > struct cmd_list_element; > > typedef void cmd_cfunc_ftype (char *args, int from_tty); > +typedef void cmd_const_cfunc_ftype (const char *args, int from_tty); > > /* This structure specifies notifications to be suppressed by a cli > command interpreter. */ > @@ -140,6 +141,19 @@ extern struct cmd_list_element *add_cmd (const char *, enum command_class, > const char *, > struct cmd_list_element **); > > +/* Like add_cmd, but no command function is specified. */ > + > +extern struct cmd_list_element *add_cmd (const char *, enum command_class, > + const char *, > + struct cmd_list_element **); > + > +/* Const-correct variant of the above. */ It'd seem a tiny bit clearer to swap the two new declarations so that this "of the above" comment is right below the const-incorrect one. > + > +extern struct cmd_list_element *add_cmd (const char *, enum command_class, > + cmd_const_cfunc_ftype *fun, > + const char *, > + struct cmd_list_element **); Otherwise OK. Thanks, Pedro Alves