Re: [PATCH v5 2/4] gdb: provide openrisc target description XML files.

Yao Qi
2017-04-04T21:25:57Z

Stafford Horne <shorne@gmail.com> writes:

> diff --git a/gdb/features/or1k.xml b/gdb/features/or1k.xml
> new file mode 100644
> index 0000000..688b340
> --- /dev/null
> +++ b/gdb/features/or1k.xml
> @@ -0,0 +1,2274 @@
> +<?xml version="1.0"?>
> +<!-- Copyright (C) 2016 Free Software Foundation, Inc.
> +
> + Copying and distribution of this file, with or without modification,
> + are permitted in any medium without royalty provided the copyright
> + notice and this notice are preserved. -->
> +
> +
> +<target>
> + <architecture>or1k</architecture>
> + <feature name="org.gnu.gdb.or1k.group0">

11 features are defined, but your patch 1/4 only checks feature group0.
Does it indicate that only group0 is a required feature? If so, we need
to document it here,
https://sourceware.org/gdb/current/onlinedocs/gdb/Standard-Target-Features.html

Of course, the debugging stub,like OpenOCD, can provide more features
than GDB required. In GDB, we need only to define required features.

--
Yao (齐尧)