From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KUTmIzxA/WnpZCAAWB0awg (envelope-from ) for ; Thu, 07 May 2026 21:45:32 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=WF2GhjmX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 807231E0BA; Thu, 07 May 2026 21:45:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5CDC71E093 for ; Thu, 07 May 2026 21:45:31 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CABDD4BA2E06 for ; Fri, 8 May 2026 01:45:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CABDD4BA2E06 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=WF2GhjmX Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 4A39B4BA540B for ; Fri, 8 May 2026 01:45:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A39B4BA540B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4A39B4BA540B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778204706; cv=none; b=CYZ/vmDwuoT4Lm5Guct3MHWzJk6jERb7x5upPBt7BLE7DIyOQ011EujDAN+tXmbuOZ1NLDmGei6oD6ZfcBL91tHGr3JaEQQd91yH8FdHd86GplXwgE0KyVSSRHppPY9C6TPUKqOi+jxtfasZbeUP+Vmlcj/qzCO/99bGevPv2MQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778204706; c=relaxed/simple; bh=ZROmoKvzRHhVr/mz1++q3xHBj25cS95Hha54ydcV8UA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=gSWsvZv5vIRwKua4qeXTk9wFgerU25JKS+GnF6ajBpkkgU//Gw1bhj+w5OWLbMEZUUdz+DnkO6dFceRGVDyr7Imvvieq51qV6QR/tTuMyS6aHT4q/N8rqbaoyAL1TMUmbhzIgPWZR3Ra7aXjFnEqftMSZncxgjWENzeVfFxAckE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=WF2GhjmX DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A39B4BA540B Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 6481ixit124049 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 7 May 2026 21:45:04 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 6481ixit124049 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1778204704; bh=BKGdQ00/E55EWmuViv9TuekJPYO+ukPergn1ki5sW+A=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=WF2GhjmXBEM/5Zv42R/XybgYE3/4V4Aveh0lhgR82x+6OOyd+AWS1tIV54bayWfpb 8cs5h9WJzQgb3J5pfwJ9IEvHEpYDov4bNHngAEJ/KseMrAlDQRl2cPKGQMhS1Er/Z7 7DV+GELplsNm5wwybjzR5K6n2JAbT7oEvBEL39hkrO52Dz4VoBALmew8zDkHW3nu47 xwAv1wft79tR0TLoV4ZZifXR8+jfaxv4BNT2o24FUjT/qFOAR5yI6Z+XdoSjRRYhS9 K7G2PsoIsb3WIRBYBny2nFAUTSiF6mC6XHxsc+mfQGwrYvbCL1AOX3/ZGC6zZxfLSt 1hf3YKtF1sZDg== Received: by simark.ca (Postfix) id 2FD081E093; Thu, 07 May 2026 21:44:57 -0400 (EDT) Message-ID: Date: Thu, 7 May 2026 21:44:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/11] gdb/solib: use early return in solib_read_symbols To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20251209193610.296085-1-simon.marchi@efficios.com> <20251209193610.296085-3-simon.marchi@efficios.com> <871pfzm55a.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <871pfzm55a.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 8 May 2026 01:44:59 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/28/26 12:16 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> From: Simon Marchi > Simon> This reduces the indent a bit, and makes it clearer where the > Simon> "interesting" part of the function is. > > Simon> At the same time, move the comment to solib.h. > > Ok. > Approved-By: Tom Tromey > > Tom Thanks, I pushed this patch. Simon