Re: [PATCH 1/5] Include the x86-bsd-nat.h header and fix the NetBSD/i386 build

Simon Marchi
2020-09-28T20:52:39Z

On 2020-09-23 9:29 a.m., Kamil Rytarowski wrote:
> On 23.09.2020 15:15, Christian Biesinger wrote:
>> On Wed, Sep 23, 2020 at 6:26 AM Kamil Rytarowski <n54@gmx.com> wrote:
>>>
>>> In file included from ../../gdb/i386-nbsd-nat.c:26:
>>> ../../gdb/i386-bsd-nat.h:34:53: error: expected template-name before '<' token
>>> 34 | class i386_bsd_nat_target : public x86bsd_nat_target<BaseTarget>
>>> | ^
>>
>> Seems like x86-bsd-nat.h should be included by i386-bsd-nat.h instead?
>>
>
> I have got no opinion. This patch replicates what FreeBSD does.

Indeed, i386-bsd-nat.h uses x86bsd_nat_target, so it needs to include
x86-bsd-nat.h. The patch is ok with that fixed.

Simon