From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121193 invoked by alias); 26 Sep 2019 14:06:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121185 invoked by uid 89); 26 Sep 2019 14:06:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=speaking X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Sep 2019 14:06:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1569506763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9rCaSF32k71Xx5/oQMnPttLi+S0XuzAB9CuRP8ZNfno=; b=U6ptL5K8INwrWoVZyX6KnkYMcoat1s3aAwyb8lbzvIGOwRWAcVW5Vr2dNUZe9G28IURLk0 E99y+Ey8EBQz24nULvMnRvQC+AyHXrtiUUqd5zrn5to2kLoCzZXMqJ/0WP1qy7I5sYF4bZ tc4R9fghHxtnpKTXQ85/+X7IdcpI8wU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-105-Er2H-pHOONazZD_5-UDjEQ-1; Thu, 26 Sep 2019 10:05:59 -0400 Received: by mail-wm1-f71.google.com with SMTP id f63so1081572wma.7 for ; Thu, 26 Sep 2019 07:05:58 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id f143sm6477916wme.40.2019.09.26.07.05.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Sep 2019 07:05:56 -0700 (PDT) Subject: Re: [RFC 09/17] Introduce async-event.[ch] To: Tom Tromey , gdb-patches@sourceware.org References: <20190224165153.5062-1-tom@tromey.com> <20190224165153.5062-10-tom@tromey.com> From: Pedro Alves Message-ID: Date: Thu, 26 Sep 2019 14:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190224165153.5062-10-tom@tromey.com> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-09/txt/msg00524.txt.bz2 On 2/24/19 4:51 PM, Tom Tromey wrote: > This patch splits out some gdb-specific code from event-loop, into new > files async-event.[ch]. Strictly speaking this code could perhaps be > put into common/, but because gdbserver does not currently use it, it > seemed better, for size reasons, to split it out. Seems fine. Going forward, I wonder whether we'll split event loop things into more files, and whether using a name prefix like "event-loop-" or "el-", like "el-async-event.[ch]" would help keeping things a bit closer together. Just a thought; not a request. Thanks, Pedro Alves