From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec103.isp.belgacom.be (mailsec103.isp.belgacom.be [195.238.20.99]) by sourceware.org (Postfix) with ESMTPS id 489A93857C42 for ; Sat, 11 Jul 2020 08:34:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 489A93857C42 IronPort-SDR: RnIrrPL7Nf+b92wvhyxxQ+UqS5fSfJEeOGRNQs3oHeZ6nFcpnuMrzHWqDiAGD1gilsLgYvvy/s dRawifpVW28bkAmivBykcTUfZl3bjCX192spnANpTFHIkSBZew9rO3c35E3YpnJ9z2PPVCeSBf aX1purtMw9YAbpCPLf/GWKTLFQR0H1Ba3DIStIGfPw9uxdR3roYZmr/jjHvzSYf044Zw8Br0Di RGfD1mc7vGn1K44SRrO6/dZsewa/mIp7CWYCi0MdUg1gGpE50AVWnkpbCrXULCdY4b0TwB1BPy LTc= IronPort-PHdr: =?us-ascii?q?9a23=3A/y8AzBSZLCNSRpvk+tBphH8CK9psv+yvbD5Q0Y?= =?us-ascii?q?Iujvd0So/mwa6ybRGN2/xhgRfzUJnB7Loc0qyK6v6mAzdLucrJ8ChbNsAVCl?= =?us-ascii?q?ld0YRetjdjKfbNMVf8Iv/uYn5yN+V5f3ghwUuGN1NIEt31fVzYry76xzcTHh?= =?us-ascii?q?LiKVg9fbytScbdgMutyu+95YDYbRlWizqhe7NyKwi9oRnMusUMjoZuN6c8xg?= =?us-ascii?q?HXrnZGdOha2WxlLk+Xkxrg+8u85pFu/zlQtv4768JMTaD2dLkkQLJFCzgrL3?= =?us-ascii?q?o779DxuxnZSguP6HocUmEInRdNHgPI8hL0UIrvvyXjruZy1zWUMsPwTbAvRD?= =?us-ascii?q?St9LxrRwPyiCcGLDE27mfagdFtga1BoRKhoxt/w5PIYIyQKfFzcL/Rcc8cSG?= =?us-ascii?q?FcWMtaSi5PDZ6mb4YXDOQPIOZWoZfzqVQMoxuxGQejC+zgxDJTmn/737c33/?= =?us-ascii?q?g9HQzc3gEtGc8FvnTOrNXyMacfSfq7zKnJzTXHbvNWwS/955bVeR8hu/6MR7?= =?us-ascii?q?VwcdPMyUkuCQzFlE6QopHiMjON1uQNsmyb7+t4VeK3lWErsQ9wrSK1xscrk4?= =?us-ascii?q?nJm4MVxU7e9SVi24s1Pt64SU59YdG6DJtcrTqVOJVvT84kXmpntzo0xKcctp?= =?us-ascii?q?6nYCgF1o4nxxjHZvCZbYSF4Q7uWemNLTtkhn9oeL2yiguy/0S8xeDyWcm63U?= =?us-ascii?q?tEoydBjNTCuG4A2hLQ58WERPZw/0es1DiA2g3X6+xJJ10/m6nDK5M53LI8i5?= =?us-ascii?q?gevV7eEiL4mUj6lqybelg+9uWm5enqZKjtqIWGOI9ukA7+N7wjmsm4AeslLA?= =?us-ascii?q?cDR3Ob+eGg1L37+k35XalKguU2kqbHtJDaItwWpqukDANN04Yj7QiwDyu+3d?= =?us-ascii?q?gGgHUKLkhJdA+JgoXoIV3DI+30Ae2xjlmiiDtrwurJPrzlApXDNHjDl7LhcK?= =?us-ascii?q?5l605cyQozydFf54pMCr4fOv7yVFX+tMbfDh8gLgy0wvjoCM9m1o4FQmKPAa?= =?us-ascii?q?+YMKXMvl+U/O4gOPeDaJcPuDnhM/gl++LujXghlF8SYKamxoIbaGiiEfR6P0?= =?us-ascii?q?qZYWTjgswaHGcRuQo+Ufbqh0GcXj9dfXmyRbwz6is8CIK8AoeQDryq1bON1m?= =?us-ascii?q?KjF4FdZm1dIkuLDG3jepqNQfpKbzidceF7lTlRbbigT445zRzmiwbgzKN6L+?= =?us-ascii?q?fO4WVMrZLi0Nlt/+CVihgo8iVpDsmHyEmWTHByk39OTTJgj/M3mlB01lrWif?= =?us-ascii?q?swuPdfD9EGv/4=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2DLAgBVeAlf/yFRiNlgHAEBAQEBAQc?= =?us-ascii?q?BARIBAQQEAQFAB4FDgxlUX4QziQGIF5wJCwEBAQEBAQEBAQgfDQECBAEBhEw?= =?us-ascii?q?CghclOBMCAwEBAQMCBQEBBgEBAQEBAQUEAYYORYI3IoMXAQUjMzMIAxgCAiY?= =?us-ascii?q?CAlcZgyeDAKgzgTKFUoNPgUCBDiqIdYQLgUw/gRGDED6FCoJJgj4iBJpCmjI?= =?us-ascii?q?oB4JggQcEC4c7kQchgnScNpNRnTeBaoF6bYM8CUcmnGdCMDcCBggBAQMJdAg?= =?us-ascii?q?TjCQtghcBAQ?= X-IPAS-Result: =?us-ascii?q?A2DLAgBVeAlf/yFRiNlgHAEBAQEBAQcBARIBAQQEAQFAB?= =?us-ascii?q?4FDgxlUX4QziQGIF5wJCwEBAQEBAQEBAQgfDQECBAEBhEwCghclOBMCAwEBA?= =?us-ascii?q?QMCBQEBBgEBAQEBAQUEAYYORYI3IoMXAQUjMzMIAxgCAiYCAlcZgyeDAKgzg?= =?us-ascii?q?TKFUoNPgUCBDiqIdYQLgUw/gRGDED6FCoJJgj4iBJpCmjIoB4JggQcEC4c7k?= =?us-ascii?q?QchgnScNpNRnTeBaoF6bYM8CUcmnGdCMDcCBggBAQMJdAgTjCQtghcBAQ?= Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO md) ([217.136.81.33]) by relay.skynet.be with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jul 2020 10:34:18 +0200 Message-ID: Subject: Re: [RFAv2] Fine tune exec-file-mismatch help and documentation. From: Philippe Waroquiers To: gdb-patches@sourceware.org Date: Sat, 11 Jul 2020 10:34:18 +0200 In-Reply-To: <20200704142352.3533-1-philippe.waroquiers@skynet.be> References: <20200704142352.3533-1-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2020 08:34:23 -0000 Ping. Thanks Philippe On Sat, 2020-07-04 at 16:23 +0200, Philippe Waroquiers wrote: > It was deemed better to explicitly mention in help and doc that build IDs > are used for comparison, and that symbols are loaded when asking to > load the exec-file. > > This is V2, fixing 2 typos and replacing 'If the user asks to load' > by 'If the user confirms loading', as suggested by Pedro. > > gdb/ChangeLog > 2020-07-04 Philippe Waroquiers > > * exec.c (_initialize_exec): Update exec-file-mismatch help. > > gdb/doc/ChangeLog > 2020-07-04 Philippe Waroquiers > > * gdb.texinfo (Attach): Update exec-file-mismatch doc. > --- > gdb/doc/gdb.texinfo | 2 ++ > gdb/exec.c | 8 ++++++-- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index fbe9f850af..eac3a3a87e 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -3016,6 +3016,8 @@ by @value{GDBN} and the executable file used to start the process. If > @samp{ask}, the default, display a warning and ask the user whether to > load the process executable file; if @samp{warn}, just display a > warning; if @samp{off}, don't attempt to detect a mismatch. > +If the user confirms loading the process executable file, then its symbols > +will be loaded as well. > > @cindex show exec-file-mismatch > @item show exec-file-mismatch > diff --git a/gdb/exec.c b/gdb/exec.c > index de473fbcb2..2ff5846c0e 100644 > --- a/gdb/exec.c > +++ b/gdb/exec.c > @@ -305,7 +305,7 @@ validate_exec_file (int from_tty) > exec_file_target = TARGET_SYSROOT_PREFIX + exec_file_target; > > warning > - (_("Mismatch between current exec-file %ps\n" > + (_("Build ID mismatch between current exec-file %ps\n" > "and automatically determined exec-file %ps\n" > "exec-file-mismatch handling is currently \"%s\""), > styled_string (file_name_style.style (), current_exec_file), > @@ -1269,7 +1269,11 @@ loaded by GDB and the exec-file automatically determined when attaching\n\ > to a process:\n\n\ > ask - warn the user and ask whether to load the determined exec-file.\n\ > warn - warn the user, but do not change the exec-file.\n\ > - off - do not check for mismatch."), > + off - do not check for mismatch.\n\ > +\n\ > +GDB detects a mismatch by comparing the build IDs of the files.\n\ > +If the user confirms loading the determined exec-file, then its symbols\n\ > +will be loaded as well."), > set_exec_file_mismatch_command, > show_exec_file_mismatch_command, > &setlist, &showlist);