From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 11/11] Change captured_mi_execute_command to use scoped_restore
Date: Thu, 28 Sep 2017 10:35:00 -0000 [thread overview]
Message-ID: <e0fb9680-fa9f-64d2-8e1d-5273d1db83bf@redhat.com> (raw)
In-Reply-To: <20170912185736.20436-12-tom@tromey.com>
On 09/12/2017 07:57 PM, Tom Tromey wrote:
> Change captured_mi_execute_command to use a scoped_restore, removing a
> cleanup. The old code copied the current token, but I don't believe
> that is necessary.
>
I tried to see if it was safe, and I think it is. I wondered whether
the command to be executed could itself run an MI command with a token,
and whether that'd clobber the original token. Like, e.g. (contrived):
321-interpreter-exec mi "123-thread-info"
we currently get:
123^done,threads=[]
321^done
(gdb)
Looks like that's OK because we create a separate parse object for each
of the commands.
> ChangeLog
> 2017-09-12 Tom Tromey <tom@tromey.com>
>
> * mi/mi-main.c (captured_mi_execute_command): Use scope_restore.
OK.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-09-28 10:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 18:57 more cleanup removal, particularly in MI Tom Tromey
2017-09-12 18:57 ` [RFA 04/11] Don't copy a string in mi_cmd_disassemble Tom Tromey
2017-09-28 9:40 ` Pedro Alves
2017-09-12 18:57 ` [RFA 05/11] Remove unused declaration Tom Tromey
2017-09-28 9:40 ` Pedro Alves
2017-09-12 18:57 ` [RFA 02/11] Remove cleanups from mi_cmd_break_insert_1 Tom Tromey
2017-09-28 9:24 ` Pedro Alves
2017-09-28 19:57 ` Tom Tromey
2017-09-29 1:40 ` Tom Tromey
2017-09-29 10:21 ` Pedro Alves
2017-09-12 18:57 ` [RFA 10/11] Use a std::vector for ada_exceptions_list Tom Tromey
2017-09-28 10:20 ` Pedro Alves
2017-09-12 18:57 ` [RFA 09/11] Use std::set in mi-main.c Tom Tromey
2017-09-28 10:10 ` Pedro Alves
2017-10-02 13:05 ` Simon Marchi
2017-10-03 11:21 ` Simon Marchi
2017-10-03 11:39 ` Tom Tromey
2017-09-12 18:57 ` [RFA 11/11] Change captured_mi_execute_command to use scoped_restore Tom Tromey
2017-09-28 10:35 ` Pedro Alves [this message]
2017-09-12 18:57 ` [RFA 08/11] Use string and unique_xmalloc_ptr in mi-main.c Tom Tromey
2017-09-28 9:57 ` Pedro Alves
2017-09-29 1:42 ` Tom Tromey
2017-09-29 10:23 ` Pedro Alves
2017-09-12 18:57 ` [RFA 07/11] Use gdb::byte_vector in mi_cmd_data_write_memory_bytes Tom Tromey
2017-09-28 9:46 ` Pedro Alves
2017-09-12 18:57 ` [RFA 06/11] Change some gdb_* functions to use a std::string out parameter Tom Tromey
2017-09-28 9:42 ` Pedro Alves
2017-09-28 19:58 ` Tom Tromey
2017-09-12 18:59 ` [RFA 01/11] Remove make_cleanup_defer_target_commit_resume Tom Tromey
2017-09-28 9:17 ` Pedro Alves
2017-09-12 19:03 ` [RFA 03/11] Remove cleanups from mi-cmd-var.c Tom Tromey
2017-09-28 9:36 ` Pedro Alves
2017-09-29 1:40 ` Tom Tromey
2017-09-29 10:22 ` Pedro Alves
2017-09-23 16:15 ` more cleanup removal, particularly in MI Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0fb9680-fa9f-64d2-8e1d-5273d1db83bf@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox