From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105500 invoked by alias); 16 Nov 2016 17:12:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105486 invoked by uid 89); 16 Nov 2016 17:12:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=ifeq, 3.80, VARIABLES X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Nov 2016 17:12:26 +0000 Received: by simark.ca (Postfix, from userid 33) id A745A1E74F; Wed, 16 Nov 2016 12:12:24 -0500 (EST) To: Andreas Schwab Subject: Re: [PATCH 2/4] Remove code that checks for GNU/non-GNU make X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 16 Nov 2016 17:12:00 -0000 From: Simon Marchi Cc: Eli Zaretskii , Simon Marchi , gdb-patches@sourceware.org In-Reply-To: References: <20161116160808.12830-1-simon.marchi@ericsson.com> <20161116160808.12830-3-simon.marchi@ericsson.com> <83mvgzfkrr.fsf@gnu.org> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00431.txt.bz2 On 2016-11-16 11:39, Andreas Schwab wrote: > On Nov 16 2016, Eli Zaretskii wrote: > >> Since GDB is built by first running Make in sibling directories, which >> don't require a GNU Make yet, what does this mean in case the user >> runs a non-GNU Make? Will they have strange errors half way through >> the build? Should we detect this early on and bail out? > > The toplevel makefile already has such a check, only enabled for gcc > for > now. Ah, great. In the discussion [1] linked by Pedro in the order thread, no one seemed to have an objection about switching binutils-gdb to require GNU make. So we can probably just make that check unconditional. Note that it's not a check for GNU make per-se, but a check for the .VARIABLES. It's equivalent if GNU make is the only one to provide the .VARIABLES variable, but I don't know if that's the case. 27 @if gcc 28 ifeq (,$(.VARIABLES)) # The variable .VARIABLES, new with 3.80, is never empty. 29 $(error GNU make version 3.80 or newer is required.) 30 endif 31 @endif gcc [1] https://sourceware.org/ml/binutils/2014-05/msg00263.html