Re: [PATCH] gdb/testsuite: Fix typos in infcall-nested-structs.c

Tom Tromey
2019-10-09T17:58:36Z

>>>>> "Andreas" == Andreas Arnez <arnez@linux.ibm.com> writes:

Andreas> Some of the comparison functions in infcall-nested-structs.c contain
Andreas> redundant comparisons like a.<some_field> == a.<some_field> instead of
Andreas> a.<some_field> == b.<some_field>. They were introduced with this commit:

Andreas> 36eb4c5f9bbe6 - "infcall-nested-structs: Test up to five fields"

Andreas> Fix the redundant comparisons.

Andreas> gdb/testsuite/ChangeLog:

Andreas> * gdb.base/infcall-nested-structs.c (cmp_struct_02_01)
Andreas> (cmp_struct_02_02, cmp_struct_04_01, cmp_struct_04_02)
Andreas> (cmp_struct_05_01, cmp_struct_static_02_01)
Andreas> (cmp_struct_static_04_01, cmp_struct_static_06_01): Fix redundant
Andreas> comparisons.

Thank you. This looks reasonable to me. I think you could have put it
in under the obvious rule, even.

Tom