From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IXK+CXawfWrqOCMAWB0awg (envelope-from ) for ; Thu, 13 Aug 2026 07:54:30 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Kl9equGR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=/zVJWRWo; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SODWQ5vn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HxhXVNNf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 206F11E166; Thu, 13 Aug 2026 07:54:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8F9D81E033 for ; Thu, 13 Aug 2026 07:54:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9557C4BA79A4 for ; Thu, 13 Aug 2026 11:54:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9557C4BA79A4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Kl9equGR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=/zVJWRWo; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SODWQ5vn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HxhXVNNf Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id BD2EB4BA798D for ; Thu, 13 Aug 2026 11:53:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD2EB4BA798D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BD2EB4BA798D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786622015; cv=none; b=bi4nWpghHdpD7haB2Dr9BaV2UNNYbunkee4z4HFIxIjbGExLJgj3svT5WUJCD0O7DP08Cv157o0Ml0JMRaAeDHyaOgtzrMx6wcEmurGqGCr/8m+3bY0K+UP8KP9mk0Z47352OB/jCgEFEa3uaMIEKn4Fpdvgp2Rd00mzohBNhDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786622015; c=relaxed/simple; bh=867jZQBNCTNpUaNDKr3s3Gxv7vuQX53W4/MSudiliU0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=PPxleMgQ1VPMJh1VXyhiTh24q9PC6LAMwcwbdyBn4O9bgdvQ9d6V1NX0nGOHCH0OKDlTcVcgtMUQn11UOxyXG1sclNm8RUvsM28RSes0clgSZSJuBXvPnCx0e+umoyTeQufn/Ssvk1FmQEcxrWBPWWyp7ujjGmeaCDafMDhHs8Y= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Kl9equGR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=/zVJWRWo; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SODWQ5vn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HxhXVNNf DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BD2EB4BA798D Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 83A263E7D; Thu, 13 Aug 2026 11:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786622010; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5+vZ/GAXsMsbDTZFwx/d2xlxs53buNY72zqyJM7CIDY=; b=Kl9equGRLRxZ+v1K6Ppyj4a8WoIbGGArOvxd/vkXJ9M1oTiA23l1GC0Tk9WCnC8EnLMC5f avYrS4NllMOdA/wjb73J3fgYWu7ywho65XioJLCY5idyjuAJCXlMKsICDvUFuRHR3SsxJZ SHPiNksqNTImCHBegpvwTQIBabAc58E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786622010; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5+vZ/GAXsMsbDTZFwx/d2xlxs53buNY72zqyJM7CIDY=; b=/zVJWRWoTB8yAupNh8VsTj5rwHXV+hxkSvDjhHCFPvZQoAshjodFu1ELLBAXN6wGKMH7Zc 5A50VVRgoWCUSEDw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SODWQ5vn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=HxhXVNNf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786622006; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5+vZ/GAXsMsbDTZFwx/d2xlxs53buNY72zqyJM7CIDY=; b=SODWQ5vngxheCRpw9HjjK+qB9GIptWxOTauT3j6g09mW+BS0ycaVjYAhI4FJsCSchwvgZF JIJ56Cs4gut5penteCTKwTOphRV24GgMwNZZgbfg6l162iKVtN/WT+W8cim+NmXAcSndRw J68jeZDuwoh13QM6tGU8AWPZ1AaElaE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786622006; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5+vZ/GAXsMsbDTZFwx/d2xlxs53buNY72zqyJM7CIDY=; b=HxhXVNNflNJ9+RafQlPd6JxPy0zXYOh8J2nXhffH2H2Fg51Rm5ZTZHJl/FlvqbvUW5LTCg /A7gNx+SCW62JmCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6D35277DDA; Thu, 13 Aug 2026 11:53:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id V2ZHGTawfWqKLwAAD6G6ig (envelope-from ); Thu, 13 Aug 2026 11:53:26 +0000 Message-ID: Date: Thu, 13 Aug 2026 13:53:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/build] Fix cli/cli-style.c build error with C++20 To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20260813025445.237662-1-tdevries@suse.de> <86cxvmaba7.fsf@gnu.org> Content-Language: en-US From: Tom de Vries In-Reply-To: <86cxvmaba7.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 83A263E7D X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns, suse.de:mid, suse.de:email, suse.de:dkim] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/13/26 6:34 AM, Eli Zaretskii wrote: >> From: Tom de Vries >> Date: Thu, 13 Aug 2026 04:54:45 +0200 >> >> PR build/34514 reports for a C++20 build: >> ... >> cli/cli-style.c:457:37: error: conversion from ‘const char8_t [8]’ to \ >> non-scalar type ‘std::string’ {aka ‘std::__cxx11::basic_string’} \ >> requested >> 457 | static std::string warning_prefix = u8"\u26A0\uFE0F "; >> | ^~~~~~~~~~~~~~~~~ >> ... >> >> The u8 literal is char[] until C++20, but char8_t[] since C++20. >> >> Fix this by using a reinterpret_cast. >> >> Tested by rebuilding using GCC 15.3.0, with and without -std=c++20. >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34514 >> --- >> gdb/cli/cli-style.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/cli/cli-style.c b/gdb/cli/cli-style.c >> index 60c00acdf43..5c26519c6d7 100644 >> --- a/gdb/cli/cli-style.c >> +++ b/gdb/cli/cli-style.c >> @@ -454,7 +454,8 @@ no_emojis () >> - uFE0F: Variation Selector-16 (VS16) >> The VS16 forces "Emoji" presentation. It is needed because the default >> presentation for Warning Sign is "Text". Together, we get: ⚠️ . */ >> -static std::string warning_prefix = u8"\u26A0\uFE0F "; >> +static std::string warning_prefix >> + = reinterpret_cast (u8"\u26A0\uFE0F "); >> >> /* Implement 'show style warning-prefix'. */ >> >> @@ -479,7 +480,8 @@ print_warning_prefix (ui_file *file) >> - u274C: Cross Mark: ❌ >> No VS16 is needed because the default presentation for Cross Mark is >> "Emoji". */ >> -static std::string error_prefix = u8"\u274C "; >> +static std::string error_prefix >> + = reinterpret_cast (u8"\u274C "); > > Thanks. May I suggest to add comments here explaining why we use > reinterpret_cast? The situation with the various C++ standards > changes with time, as we require newer versions of the standard, so at > some point this will no longer be needed. And use of reinterpret_cast > is unusual enough to raise some brows anyway. Hi Eli, I've sent a patch that adds a comment but also replaces the reinterpret_cast ( https://sourceware.org/pipermail/gdb-patches/2026-August/229432.html ). Thanks, - Tom