From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] [gdb/symtab] Remove COMPUNIT_CALL_SITE_HTAB
Date: Fri, 1 Oct 2021 09:13:23 -0400 [thread overview]
Message-ID: <e0574877-73c4-aa72-b0dd-02142ff6723c@polymtl.ca> (raw)
In-Reply-To: <20211001123328.22314-2-tdevries@suse.de>
On 2021-10-01 08:33, Tom de Vries via Gdb-patches wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> Remove macro COMPUNIT_CALL_SITE_HTAB, and provide access to the htab using
> member functions:
> - compunit_symtab::find_call_site
> - compunit_symtab::set_call_site_htab
>
> Tested on x86_64-linux.
>
> Co-Authored-By: Tom de Vries <tdevries@suse.de>
LGTM, but I wrote some of it, so I'm not really impartial here.
Simon
next prev parent reply other threads:[~2021-10-01 13:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 12:33 [PATCH 1/4] [gdb/symtab] Fix htab_find_slot call in read_call_site_scope Tom de Vries via Gdb-patches
2021-10-01 12:33 ` [PATCH 2/4] [gdb/symtab] Remove COMPUNIT_CALL_SITE_HTAB Tom de Vries via Gdb-patches
2021-10-01 13:13 ` Simon Marchi via Gdb-patches [this message]
2021-10-01 12:33 ` [PATCH 3/4] [gdb/symtab] Add call_site::pc () Tom de Vries via Gdb-patches
2021-10-01 18:10 ` Simon Marchi
2021-10-04 16:45 ` Tom de Vries via Gdb-patches
2021-10-01 12:33 ` [PATCH 4/4] [gdb/symtab] Use unrelocated addresses in call_site Tom de Vries via Gdb-patches
2021-10-01 20:56 ` Simon Marchi via Gdb-patches
2021-10-04 16:47 ` Tom de Vries via Gdb-patches
2021-10-01 13:09 ` [PATCH 1/4] [gdb/symtab] Fix htab_find_slot call in read_call_site_scope Simon Marchi via Gdb-patches
2021-10-03 19:34 ` Tom de Vries via Gdb-patches
2021-10-04 12:05 ` Simon Marchi via Gdb-patches
2021-10-04 12:46 ` Tom de Vries via Gdb-patches
2021-10-04 15:41 ` Simon Marchi via Gdb-patches
2021-10-04 16:14 ` Tom de Vries via Gdb-patches
2021-10-04 16:34 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0574877-73c4-aa72-b0dd-02142ff6723c@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox