From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39718 invoked by alias); 27 Feb 2020 19:20:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39667 invoked by uid 89); 27 Feb 2020 19:20:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:4fa9a25, HX-Languages-Length:616, H*f:sk:4fa9a25, H*MI:sk:4fa9a25 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Feb 2020 19:20:53 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 719CC1E5F9; Thu, 27 Feb 2020 14:20:45 -0500 (EST) Subject: Re: [PATCH] gdb: Check for nullptr when computing srcpath From: Simon Marchi To: Aaron Merey , gdb-patches@sourceware.org References: <4fa9a257-f805-c9b7-cae7-8c13ea438e14@simark.ca> Message-ID: Date: Thu, 27 Feb 2020 19:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <4fa9a257-f805-c9b7-cae7-8c13ea438e14@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg01021.txt.bz2 On 2020-02-27 2:18 p.m., Simon Marchi wrote: > On 2020-02-27 1:00 p.m., Aaron Merey wrote: >> > > Hi Aaron, > > Please provide in the commit message an explanation of what this fixes, including > how to reproduce the crash. Since this fixes the execution of an existing test > case, you can include the "make check" command line used to run it, like: > > make check TESTS="gdb.dwarf2/dw2-ranges-base" > > Simon > Also, do you think you'd be able to send your patches using git-send-email? That makes it much easier to read and comment on. Thanks, Simon