From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 09F51385DC05 for ; Sat, 11 Apr 2020 23:49:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 09F51385DC05 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 865D21E827; Sat, 11 Apr 2020 19:49:25 -0400 (EDT) Subject: Re: [PATCH v4] Implement "info proc mappings" for NetBSD To: Kamil Rytarowski , gdb-patches@sourceware.org Cc: tom@tromey.com References: <20200406093753.13772-1-n54@gmx.com> <20200411234507.17070-1-n54@gmx.com> From: Simon Marchi Message-ID: Date: Sat, 11 Apr 2020 19:49:25 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200411234507.17070-1-n54@gmx.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2020 23:49:27 -0000 On 2020-04-11 7:45 p.m., Kamil Rytarowski wrote: > Define nbsd_nat_target::find_memory_regions and > nbsd_nat_target::info_proc. info_proc handles as of now only > the "mappings" command. > > Define a local static function kinfo_get_vmmap() that reads > the process memory layout of a specified process. > kinfo_get_vmmap() wraps the sysctl(3) call. > > nbsd-tdep.c defines now utility functions for printing the > process memory layout: > * nbsd_info_proc_mappings_header() > * nbsd_vm_map_entry_flags() > * nbsd_info_proc_mappings_entry() When sending a new version, can you please rebase it on the current master? The patch does not apply cleanly on master today, so it doesn't really reflect what's going to be merged. Simon