From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46553 invoked by alias); 13 Apr 2018 12:55:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46101 invoked by uid 89); 13 Apr 2018 12:55:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Apr 2018 12:54:59 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CCDD5401DEA7; Fri, 13 Apr 2018 12:54:57 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F294D7DF9; Fri, 13 Apr 2018 12:54:57 +0000 (UTC) Subject: Re: [PATCH 2/3] gdb/testsuite: Filter out some registers for riscv To: Palmer Dabbelt , andrew.burgess@embecosm.com References: Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 13 Apr 2018 12:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00251.txt.bz2 On 04/10/2018 09:25 PM, Palmer Dabbelt wrote: > On Mon, 09 Apr 2018 15:26:07 PDT (-0700), andrew.burgess@embecosm.com wrote: >> Let me know how you'd feel about leaving this as it is for now, and >> extending the filter list at a later date. > > I think it's fine for now, we can fix it when another test fails :) This is OK, then. For the register lists, I wonder whether a better option would be to instead let gdb determine which registers should be compared, instead of hard coding in the testcase. Like, look at the save/restore reggroups instead of all registers. Thanks, Pedro Alves