From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XeBGJHL2BWaHChoAWB0awg (envelope-from ) for ; Thu, 28 Mar 2024 19:00:02 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=y3sX6+AL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 816341E0C0; Thu, 28 Mar 2024 19:00:02 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 693571E08C for ; Thu, 28 Mar 2024 19:00:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1C8FB385842D for ; Thu, 28 Mar 2024 23:00:00 +0000 (GMT) Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id A0E5E3858283 for ; Thu, 28 Mar 2024 22:59:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A0E5E3858283 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A0E5E3858283 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1033 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711666756; cv=none; b=o4290v0OFOT1plh9lSMA/L25AVRZfPT1pWb5UHTPs1v79zZaUAd3QrD5LOXm4+WX3dLFViUBU4+bk5gCiFA00O1RMEQBO6HRO9mUG5jh/RMMJIw6Vd/KZGgR8BseXPUvIvFXjMHJH29TjT8ozifg3tRDhjAEWvAqFSK+7dQu0PQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711666756; c=relaxed/simple; bh=Wn1TLoOJVbfDkmwAGYXbXtEbaRFh7tEmAJHSFO1aX34=; h=DKIM-Signature:Subject:To:From:Message-ID:Date:MIME-Version; b=kfLlWt24IZWrXBeuwtzu5E/wIZ/E3ZRbBatn08hY3zNGavlM8a2D3wFxEjUalwTybDNCYLflAxXLAcIRywCsI1bNg+phlJDnGMmHiR4GDfFs++fRi1mZ5HcEqljJnz6ImGaiAOtmwpihfbI7YVHmuH+FhxYJrysTUJ9OsUZkk5c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-29c14800a7fso1115444a91.2 for ; Thu, 28 Mar 2024 15:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711666752; x=1712271552; darn=sourceware.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=5jMPK6TXVOORCYhdsmNGWcQ2mdXi258Ki1Pr3NDtcA4=; b=y3sX6+ALZozjUx/7Gz0RDNsEYYFN1fO3jYXGNCXwo7vQdbBwt+BxOJ6FOOJj7zbRP3 kePVy5+odIF/Kxu1JF1yC7jCQJh27iHqg5HhNmwa9XTsGHFCEeSJWLvNatvtpAzS4FxK O+gsb5Mse/gjtXJ/jGYJHBESGHAO8ZP20Mf0wOarWHFlcU7kshc2d+XRzWg8sfHPSxhs QW1nog2KLqvU94Q4SIvKecdmN/rrWnhmrr1pvIVTDa+k4ndd6z+x+e5uUSSUpmj4KXKC 7whDSZOfGBxYu1YvCNp2x4Rr7xtecD/lUa2/g+A4Ac0D4OU8G5OTd3pPmJ1v7bo4Hul9 Ozjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711666752; x=1712271552; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5jMPK6TXVOORCYhdsmNGWcQ2mdXi258Ki1Pr3NDtcA4=; b=dofK1HKILXyC3S/ISVx4fNzhlqpcHec5ZiGVtOvDiSEYe1yiv4SVX+8EkRkFiHctVk bixyZawugY9SxUqBo1la3xZuQ32dOuCq8R6jxZCx4wuqk9TPJ+a3175+5zk69r49z+B8 VmEt216x1ZwTjOkSqD1fur6Yi27U5tFEtvmGYi2+aN15uSFZNf8N3tmvh52SRn10NYap FfrkkPOqg0XYsLW9TYWe1VOfg1f6X+Lu/ru+9EAD19ECcVo3LLQCXgouqMQj7FlIL9ZZ L4BaM/ekoD2SaGYY3O85v39O9jp8QZQ/BUU0KTphEWquutkFh4ow5RxV/1roS7rmCcqu vueg== X-Forwarded-Encrypted: i=1; AJvYcCWte0kK5kQxdrpglK9UJjUxxU7mEEkhSa0zVGWnOrEAVSoC4rqTjHwsiJqzf3bOM03yY6bQiM+1nQ63Bdr1CzBtbVrl5pvbtBM/Cw== X-Gm-Message-State: AOJu0YwM8Of3Hudkaqtfhfjm3U4ZhepO6ywWqAC2mkyHMWwNwV7GHU6K ut7Us7amHf041pOHMdR2fsoi7Gx6Fb8FndUAN8WwXUfNXMFEIJYBtLAATwMw2Ss= X-Google-Smtp-Source: AGHT+IHvmA/7wDjULYyyYYaJginZNWx/CqmgdHsxSaLoamlxkTUNsxoWFxAwWFOmZ7ZNIx85ogm5oA== X-Received: by 2002:a17:902:b18a:b0:1e0:2a5f:d1d6 with SMTP id s10-20020a170902b18a00b001e02a5fd1d6mr870530plr.63.1711666752586; Thu, 28 Mar 2024 15:59:12 -0700 (PDT) Received: from ?IPv6:2804:7f0:b402:d0dc:4f31:e30e:9a7a:2717? ([2804:7f0:b402:d0dc:4f31:e30e:9a7a:2717]) by smtp.gmail.com with ESMTPSA id b6-20020a170902d88600b001e0c568ae8fsm2170541plz.192.2024.03.28.15.59.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 15:59:12 -0700 (PDT) Subject: Re: [PATCH 0/4] Add another way to check for MTE-tagged addresses on remote targets To: Luis Machado , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20240328070055.2578783-1-gustavo.romero@linaro.org> <905a394c-c6d3-4721-bc60-dfe31dcc4a64@arm.com> From: Gustavo Romero Message-ID: Date: Thu, 28 Mar 2024 19:59:08 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <905a394c-c6d3-4721-bc60-dfe31dcc4a64@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Hi Luis, On 3/28/24 10:00 AM, Luis Machado wrote: > Hi Gustavo, > > On 3/28/24 07:00, Gustavo Romero wrote: >> This series introduces a new method to check for MTE-tagged addresses on >> remote targets. >> >> A new remote packet, qMemTagAddrCheck, is introduced, along with a new >> remote feature associated with it, 'memory-tagging-check-add+'. Only >> when 'memory-tagging-check-add+' feature is advertised GDB will use the >> new packet to query if an address is tagged. >> >> This new mechanism allows for checking MTE addresses in an OS-agnostic >> way, which is necessary when debugging targets that do not support >> '/proc//smaps', as the current method of reading smaps contents >> fails in such cases. >> >> Cheers, >> Gustavo >> >> Gustavo Romero (4): >> gdb: aarch64: Remove MTE address checking from get_memtag >> gdb: aarch64: Move MTE address check out of set_memtag >> gdb: aarch64: Remove MTE address checking from memtag_matches_p >> gdb: Add new remote packet to check if address is tagged >> >> gdb/aarch64-linux-nat.c | 8 +++++ >> gdb/aarch64-linux-tdep.c | 22 +++----------- >> gdb/arch-utils.c | 2 +- >> gdb/arch-utils.h | 2 +- >> gdb/corelow.c | 8 +++++ >> gdb/gdbarch-gen.h | 4 +-- >> gdb/gdbarch.c | 2 +- >> gdb/gdbarch_components.py | 2 +- >> gdb/printcmd.c | 29 +++++++++++------- >> gdb/remote.c | 62 +++++++++++++++++++++++++++++++++++++++ >> gdb/target-delegates.c | 28 ++++++++++++++++++ >> gdb/target.c | 6 ++++ >> gdb/target.h | 6 ++++ >> 13 files changed, 147 insertions(+), 34 deletions(-) >> > > Thanks for the series. Please bear with me while I go through it and try it on my end. Thanks a lot! I've sent a v2 [0] that fixes a build error and also has instructions on how to build a QEMU gdbstub that supports the new packet so it's possible to test the remote target with this series. Cheers, Gustavo [0] https://sourceware.org/pipermail/gdb-patches/2024-March/207650.html