From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16830 invoked by alias); 17 Mar 2006 16:07:57 -0000 Received: (qmail 16814 invoked by uid 22791); 17 Mar 2006 16:07:56 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Mar 2006 16:07:55 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1FKHUJ-0001Du-Br for gdb-patches@sources.redhat.com; Fri, 17 Mar 2006 17:07:39 +0100 Received: from zigzag.lvk.cs.msu.su ([158.250.17.23]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 17 Mar 2006 17:07:39 +0100 Received: from ghost by zigzag.lvk.cs.msu.su with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 17 Mar 2006 17:07:39 +0100 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: MI: type prefixes for values Date: Fri, 17 Mar 2006 19:32:00 -0000 Message-ID: References: <17427.54333.236860.258115@kahikatea.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.8.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00228.txt.bz2 Nick Roberts wrote: > 2006-03-12 Nick Roberts > > * mi/mi-cmd-stack.c (list_args_or_locals): Use common_val_print > instead of print_variable_value so that type doesn't get printed > with value. This patch is much more important that value formatting, in fact. Without it, if there's local reference variable that's no initialized, we get this output from gdb: (gdb) -stack-list-locals --all-values Cannot access memory at address 0x1 ^error,msg="Cannot access memory at address 0x1" Essentially, I can't see any local variables. This patch fixes this too, because, I believe, common_val_print does check for non-dereferencable values. Changelogs say common_val_print was specifically added for this purpose. - Volodya